✨ (signer-eth) [DSDK-617]: Remove ethers dependency from api and accept only raw tx #591
+307
−988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jiyuzhuang
reviewed
Jan 6, 2025
| "@ledgerhq/device-signer-kit-ethereum": minor | ||
| --- | ||
|
|
||
| Breaking change: remove ethers from api dependency and use only raw tx for signTransaction |
There was a problem hiding this comment.
Not sure if 'breaking change' wording is compatible to minor versioning.
There was a problem hiding this comment.
agree but basically for signers we shouldn't have release v1.0 it was more 1.0-rc
jiyuzhuang
reviewed
Jan 6, 2025
| @@ -46,7 +46,7 @@ describe("DefaultSignerEth", () => { | |||
| it("should sign a transaction", async () => { | |||
| // GIVEN | |||
| const derivationPath = "derivationPath"; | |||
| const transaction = {} as Transaction; | |||
| const transaction = new Uint8Array(0); | |||
There was a problem hiding this comment.
[COULD] I think the 0 parameter is not necessary to initialise a fake data, new Uint8Array() is OK, but not important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR aims to remove the multiple
ethersdependency from the api.From now on, we only need to provide the raw transaction to a
signTransaction. TheTransactionobject fromethersversionsv5andv6are no longer supported, and there are no plans to integrate other Ethereum libraries since they all provide ways to retrieve the raw transaction.We internally use
ethersv6for parsing. We don't need it anymore on thesampleside as we use directly raw format.❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
signTransactiontakes now a raw transaction instead ofethersTransactionobject.🧐 Checklist for the PR Reviewers