Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 (signers) [NO-ISSUE]: Polish signer's readme #599

Merged
merged 1 commit into from
Jan 20, 2025
Merged

📝 (signers) [NO-ISSUE]: Polish signer's readme #599

merged 1 commit into from
Jan 20, 2025

Conversation

fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Jan 10, 2025 •
edited
Loading

📝 Description

Polished signers readme and added BTC readme

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 11:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 11:27am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

Messages
✅ Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against 7149c61

@fAnselmi-Ledger fAnselmi-Ledger force-pushed the chore/no-issue-polish-signers-readme branch from c8f7abb to cdd16f8 Compare January 10, 2025 16:01
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the chore/no-issue-polish-signers-readme branch from cdd16f8 to 166abdd Compare January 10, 2025 16:03
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the chore/no-issue-polish-signers-readme branch from 166abdd to 95e1d2b Compare January 10, 2025 16:57
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the chore/no-issue-polish-signers-readme branch from 95e1d2b to d2e684e Compare January 20, 2025 11:13
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the chore/no-issue-polish-signers-readme branch from d2e684e to 7149c61 Compare January 20, 2025 11:22
aussedatlo
aussedatlo approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@aussedatlo aussedatlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, easier to read 👍

@fAnselmi-Ledger fAnselmi-Ledger marked this pull request as ready for review January 20, 2025 14:28
@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner January 20, 2025 14:28
@fAnselmi-Ledger fAnselmi-Ledger added this pull request to the merge queue Jan 20, 2025
Merged via the queue into develop with commit c0558e2 Jan 20, 2025
10 checks passed
@fAnselmi-Ledger fAnselmi-Ledger deleted the chore/no-issue-polish-signers-readme branch January 20, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aussedatlo aussedatlo aussedatlo approved these changes

Assignees

@fAnselmi-Ledger fAnselmi-Ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fAnselmi-Ledger @aussedatlo