♻️ (signer-solana) [NO-ISSUE]: Improve error handling #626
+292
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
fAnselmi-Ledger
force-pushed
the
chore/no-issue-refactor-solana-error-handling
branch
from
adae7d7 to
fa7f949
Compare
fAnselmi-Ledger
force-pushed
the
chore/no-issue-refactor-solana-error-handling
branch
from
fa7f949 to
4ae8617
Compare
fAnselmi-Ledger
changed the title
valpinkman
requested changes
Jan 23, 2025
packages/signer/signer-solana/src/internal/app-binder/command/GetAppConfigurationCommand.ts
Outdated
Show resolved
Hide resolved
packages/signer/signer-solana/src/internal/app-binder/task/SendSignDataTask.test.ts
Outdated
Show resolved
Hide resolved
fAnselmi-Ledger
force-pushed
the
chore/no-issue-refactor-solana-error-handling
branch
from
4ae8617 to
f98a6c9
Compare
fAnselmi-Ledger
force-pushed
the
chore/no-issue-refactor-solana-error-handling
branch
from
f98a6c9 to
551fd56
Compare
aussedatlo
reviewed
Jan 23, 2025
packages/signer/signer-solana/src/api/app-binder/GetAddressDeviceActionTypes.ts
Outdated
Show resolved
Hide resolved
...r/signer-solana/src/internal/app-binder/device-action/SignMessage/SignMessageDeviceAction.ts
Outdated
Show resolved
Hide resolved
fAnselmi-Ledger
force-pushed
the
chore/no-issue-refactor-solana-error-handling
branch
from
551fd56 to
fdb6aa0
Compare
fAnselmi-Ledger
force-pushed
the
chore/no-issue-refactor-solana-error-handling
branch
from
fdb6aa0 to
22d1ec0
Compare
aussedatlo
approved these changes
Jan 23, 2025
valpinkman
approved these changes
Jan 23, 2025
fAnselmi-Ledger
deleted the
chore/no-issue-refactor-solana-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Improve error handling
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers