Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clean] ENV declared with new syntax instead of legacy one #149

Merged
merged 2 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.XX.X] - 2024-??-??

### Fixed
- Cleaned legacy notation for ENV instruction

## [3.39.0] - 2024-10-18

### Changed
Expand Down
4 changes: 2 additions & 2 deletions legacy/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest AS LITE_BUILDER

FROM ubuntu:22.04
ENV LANG C.UTF-8
ENV LANG=C.UTF-8

ARG DEBIAN_FRONTEND=noninteractive

Expand Down Expand Up @@ -39,7 +39,7 @@ RUN cd /usr/bin && \

# ARM Embedded Toolchain
# Integrity is checked using the MD5 checksum provided by ARM at https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm/downloads
ENV TOOLCHAIN_VERSION 10.3-2021.10
ENV TOOLCHAIN_VERSION=10.3-2021.10
RUN case $(uname -m) in \
x86_64 | amd64) \
ARCH=x86_64 \
Expand Down
2 changes: 1 addition & 1 deletion lite/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM alpine:3.15
ENV LANG C.UTF-8
ENV LANG=C.UTF-8

RUN apk update
RUN apk upgrade
Expand Down
Loading