Update for Rust needs #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xchapron-ledger
requested review from
agrojean-ledger,
lpascal-ledger,
apaillier-ledger and
yhql
and removed request for
lpascal-ledger
agrojean-ledger
approved these changes
Sep 14, 2023
added 4 commits
September 14, 2023 16:51
xchapron-ledger
force-pushed
the
xch/rust-needs
branch
from
aee256d
to
dd70dc6
Compare
lpascal-ledger
approved these changes
Sep 14, 2023
| @@ -1,5 +1,11 @@ | |||
| FROM ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest | |||
|
|
|||
| ARG RUST_STABLE_VERSION=1.72.0 | |||
| ARG RUST_NIGHTLY_VERSION=nightly-2022-12-02 | |||
There was a problem hiding this comment.
I can't remember why we pinned this nightly version. It feel fairly old already. If we know why, we should add a comment explaining it. Else, mabe we could use a newer version?
There was a problem hiding this comment.
At that time it was pretty recent. But yeah we should update it.
apaillier-ledger
approved these changes
Sep 14, 2023
yhql
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.