feat: use correct status word when device is locked #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
force-pushed
the
feat/zondax-2
branch
from
682a66a
to
18481b5
Compare
|
Thank you, we actually intercept and handle this incorrect status word to know when the app is locked. https://github.com/iron-fish/ironfish/blob/staging/ironfish-cli/src/ledger/ledger.ts#L44-L49 This is a great fix, looking forward to getting this merged and released. @ |
yogh333
requested changes
Oct 8, 2024
yogh333
approved these changes
Oct 8, 2024
|
@emmanuelm41 Sorry, but could you please revert the last commit (merge master branch) + rebase your PR 🙏 ? |
emmanuelm41
force-pushed
the
feat/zondax-2
branch
from
138f167
to
18481b5
Compare
emmanuelm41
force-pushed
the
feat/zondax-2
branch
from
18481b5
to
2c5cdcb
Compare
|
@yogh333 rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the app is active, and the device gets locked, the device returns "Instruction Not Supported". It does not seem correct, as the instruction is indeed supported. The device is actually locked instead. I changed the status word used on this scenario, in order to inform properly to the client.