Remove HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS flag (always active on al…

…l devices)
LedgerHQ · Sep 5, 2023 · 701c243 · 701c243
1 parent 4fb902d
commit 701c243
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 10 deletions.
diff --git a/include/os_endorsement.h b/include/os_endorsement.h
@@ -16,6 +16,4 @@ SYSCALL unsigned int os_endorsement_key1_get_app_secret(unsigned char* buffer PL
 SYSCALL unsigned int os_endorsement_key1_sign_data(unsigned char* src PLENGTH(srcLength), unsigned int srcLength, unsigned char* signature PLENGTH(ENDORSEMENT_MAX_ASN1_LENGTH));
 SYSCALL unsigned int os_endorsement_key2_derive_sign_data(unsigned char* src PLENGTH(srcLength), unsigned int srcLength, unsigned char* signature PLENGTH(ENDORSEMENT_MAX_ASN1_LENGTH));
 
-#ifdef HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS
 SYSCALL unsigned int os_endorsement_get_metadata(unsigned char index, unsigned char* buffer PLENGTH(8));
-#endif // HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS
diff --git a/include/syscalls.h b/include/syscalls.h
@@ -195,9 +195,7 @@
 #define SYSCALL_os_bolos_custom_ca_revoke_ID                       0x00000CA1
 #endif // HAVE_CUSTOM_CA_DETAILS_IN_SETTINGS
 
-#ifdef HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS
 #define SYSCALL_os_bolos_endorsement_revoke_ID                     0x010001ED
-#endif
 
 #ifndef HAVE_BOLOS_NO_CUSTOMCA
 #define SYSCALL_os_customca_verify_ID                              0x03000090
@@ -221,9 +219,7 @@
 #define SYSCALL_os_aem_is_pin_validated_ID                         0x00000147
 #endif // HAVE_AEM_PIN
 
-#ifdef HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS
 #define SYSCALL_os_endorsement_get_metadata_ID                     0x02000138
-#endif // HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS
 
 #if defined(HAVE_VAULT_RECOVERY_ALGO)
 #define SYSCALL_os_perso_derive_and_prepare_seed_ID                0x02000137

diff --git a/src/syscalls.c b/src/syscalls.c
@@ -1563,14 +1563,12 @@ void os_bolos_custom_ca_revoke(void) {
 }
 #endif //HAVE_CUSTOM_CA_DETAILS_IN_SETTINGS
 
-#ifdef HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS
 bolos_bool_t os_bolos_endorsement_revoke(uint8_t slot) {
   unsigned int parameters[1];
   parameters[0] = (unsigned int) slot;
   bolos_bool_t ret = SVC_Call(SYSCALL_os_bolos_endorsement_revoke_ID, parameters);
   return ret;
 }
-#endif
 
 #ifdef HAVE_MCU_SERIAL_STORAGE
 unsigned int os_seph_serial ( unsigned char * serial, unsigned int maxlength ) {
@@ -1771,14 +1769,12 @@ bolos_bool_t os_aem_is_pin_validated ( void ) {
 }
 #endif // HAVE_AEM_PIN
 
-#ifdef HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS
 unsigned int os_endorsement_get_metadata ( unsigned char index, unsigned char * buffer ) {
   unsigned int parameters[2];
   parameters[0] = (unsigned int)index;
   parameters[1] = (unsigned int)buffer;
   return (unsigned int) SVC_Call(SYSCALL_os_endorsement_get_metadata_ID, parameters);
 }
-#endif // HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS
 
 #if defined(HAVE_LANGUAGE_PACK)
 void list_language_packs(UX_LOC_LANGUAGE_PACK_INFO *packs) {