Endorsement display #369
Merged
Endorsement display #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeBonnaz
force-pushed
the
endorsement_display
branch
from
f809228
to
a8e4e62
Compare
PhilippeBonnaz
force-pushed
the
endorsement_display
branch
from
249180c
to
75a719a
Compare
PhilippeBonnaz
requested review from
yhql,
abonnaudet-ledger and
nroggeman-ledger
nroggeman-ledger
approved these changes
Aug 1, 2023
yhql
approved these changes
Aug 1, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 69.09% 69.09%
=======================================
Files 11 11
Lines 864 864
=======================================
Hits 597 597
Misses 267 267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PhilippeBonnaz
force-pushed
the
endorsement_display
branch
2 times, most recently
from
72c1825
to
34d9cce
Compare
PhilippeBonnaz
force-pushed
the
endorsement_display
branch
from
34d9cce
to
125850b
Compare
Add HAVE_ENDORSEMENT_DETAILS_IN_SETTINGS compil flag
PhilippeBonnaz
force-pushed
the
endorsement_display
branch
from
125850b
to
35be215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes modifications needed by the OS for the new endorsements feature
Changes include
Breaking changes
This PR removes precompiler macros, thus activating by default features that were not activated on previous OS releases => breaking change