Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable os_perso_is_pin_set for non-privileged applications #391

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

srasoamiaramanana-ledger
Copy link
Contributor

@srasoamiaramanana-ledger srasoamiaramanana-ledger commented Jul 31, 2023

Description

Make os_perso_is_pin_set available to regular applications when processing default apdu.

Changes include

  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Change the syscall's privilege.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f5eb07f) 69.09% compared to head (767f8c5) 69.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files          11       11           
  Lines         864      864           
=======================================
  Hits          597      597           
  Misses        267      267           
Flag Coverage Δ
unittests 69.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srasoamiaramanana-ledger srasoamiaramanana-ledger merged commit 5f4ab50 into master Aug 9, 2023
160 checks passed
@srasoamiaramanana-ledger srasoamiaramanana-ledger deleted the fix-default-apdu branch August 9, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants