Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep only sdk errors in errors.h #401

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

srasoamiaramanana-ledger
Copy link
Contributor

@srasoamiaramanana-ledger srasoamiaramanana-ledger commented Aug 8, 2023

Description

Keep only sdk errors in errors.h.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (d31f67c) 69.09% compared to head (17a0ea0) 69.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files          11       11           
  Lines         864      864           
=======================================
  Hits          597      597           
  Misses        267      267           
Flag Coverage Δ
unittests 69.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srasoamiaramanana-ledger srasoamiaramanana-ledger force-pushed the move-error-codes branch 3 times, most recently from 75a082b to 00658af Compare August 8, 2023 14:36
@srasoamiaramanana-ledger
Copy link
Contributor Author

Change ERR_APD_LEN to ERR_APP_APD_LEN in app-mimblewimblecoin: https://github.com/LedgerHQ/app-mimblewimblecoin/blob/master/src/continue_decrypting_slate.c#L75

include/errors.h Outdated Show resolved Hide resolved
include/errors.h Outdated Show resolved Hide resolved
include/errors.h Outdated Show resolved Hide resolved
src/os_io_task.c Outdated Show resolved Hide resolved
@srasoamiaramanana-ledger srasoamiaramanana-ledger merged commit baf405d into master Sep 1, 2023
160 checks passed
@srasoamiaramanana-ledger srasoamiaramanana-ledger deleted the move-error-codes branch September 1, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants