Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick for API_LEVEL_12 #404

Merged
merged 13 commits into from
Aug 18, 2023
Merged

Cherry pick for API_LEVEL_12 #404

merged 13 commits into from
Aug 18, 2023

Conversation

xchapron-ledger
Copy link
Contributor

@xchapron-ledger xchapron-ledger commented Aug 10, 2023 •
edited
Loading

Description

Cherry picks from:

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Xavier Chapron and others added 11 commits August 10, 2023 11:34
CI: Fix codespell
9c1f4f5 
(cherry picked from commit 95f7643)
@sgliner-ledger
standard_app: allow URL to be defined in app makefile
4fe5191 
(cherry picked from commit b570644)
lib_standard_app/crypto_helpers.c: Fix bad cleanup of private key
134a351 
(cherry picked from commit f4097de)
@apaillier-ledger
Fix DEBUG=1 builds with USB disabled
fb0a703 
(cherry picked from commit 8cd6af8)
@apaillier-ledger
Can now compile without BAGL/NBGL
3a84a8d 
(cherry picked from commit 2e3934e)
@apaillier-ledger
Fix IO function call during init when IO is disabled
9086f77 
(cherry picked from commit 0d8446d)
@apaillier-ledger
SEPROXYHAL can now be disabled in standard_app Makefile
acce1af 
(cherry picked from commit 8cd9382)
@apaillier-ledger
Removed always-on SDK_SOURCE_PATH for Stax nfc & qrcode
42aa940 
(cherry picked from commit aee2e38)
@apaillier-ledger
Make nbgl compilable without qrcode in the SDK_SOURCE_PATH
42e6b1f 
(cherry picked from commit 8921ad5)
@fbeutin-ledger
Add empty .data section enforcer in loader scripts for all targets
6d63c73 
(cherry picked from commit 58b4b6f)
@fbeutin-ledger
Add empty .bss section enforcer in loader scripts for plugin compilation
3d93c92 
(cherry picked from commit 9988903)
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (API_LEVEL_12@e6bbd8f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             API_LEVEL_12     #404   +/-   ##
===============================================
  Coverage                ?   69.37%           
===============================================
  Files                   ?       11           
  Lines                   ?      875           
  Branches                ?        0           
===============================================
  Hits                    ?      607           
  Misses                  ?      268           
  Partials                ?        0
Flag Coverage Δ
unittests 69.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger merged commit 11fdad0 into API_LEVEL_12 Aug 18, 2023
160 checks passed
@xchapron-ledger xchapron-ledger deleted the xch/cherry-pick12 branch August 18, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

@apaillier-ledger apaillier-ledger apaillier-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xchapron-ledger @codecov-commenter @apaillier-ledger @fbeutin-ledger @sgliner-ledger