Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix APPNAME handling in standard app Makefile #415

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix APPNAME handling in standard app Makefile #415

merged 1 commit into from
Aug 31, 2023

Conversation

apaillier-ledger
Copy link
Contributor

Description

Spaces would not be handled properly in the CFLAGS given to the compiler when added with DEFINES, it would be visibly wrong when seen on the Stax app home screen.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger merged commit 8b2b9cb into master Aug 31, 2023
160 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/appname_with_spaces branch August 31, 2023 15:17
This was referenced Sep 1, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchapron-ledger xchapron-ledger xchapron-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaillier-ledger @xchapron-ledger