Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fat: Extend compression to smaller images #421

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

abonnaudet-ledger
Copy link
Member

Description

Work on glyphs generation script.

Smaller images were excluded from compression (because compression is incompatible with geometry transformation, and smaller images are the only ones being transformed). This commit adds the possibility to exclude an image from compression by suffixing it with "_nocomp". This allow to compress images that were not compressed before.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Work on glyphs generation script.

Smaller images were excluded from compression (because compression is
incompatible with geometry transformation, and smaller images are the
only ones being transformed). This commit adds the possibility to exclude an image from compression by suffixing it with
"_nocomp". This allow to compress images that were not compressed
before.
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d5b0435) 69.37% compared to head (8643aa6) 69.37%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   69.37%   69.37%           
=======================================
  Files          11       11           
  Lines         875      875           
=======================================
  Hits          607      607           
  Misses        268      268           
Flag Coverage Δ
unittests 69.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abonnaudet-ledger abonnaudet-ledger merged commit a5e2d10 into master Sep 12, 2023
160 checks passed
@abonnaudet-ledger abonnaudet-ledger deleted the abo_compress_small_images branch September 12, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants