Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cx_ecdsa_verify #439

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

fbeutin-ledger
Copy link
Contributor

Description

Deprecate cx_ecdsa_verify, as cx_ecdsa_verify_no_throw exists

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2ca981) 69.33% compared to head (bc35028) 69.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #439   +/-   ##
=======================================
  Coverage   69.33%   69.33%           
=======================================
  Files          11       11           
  Lines         874      874           
=======================================
  Hits          606      606           
  Misses        268      268           
Flag Coverage Δ
unittests 69.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger merged commit fe88759 into master Sep 27, 2023
160 checks passed
@xchapron-ledger xchapron-ledger deleted the fbe/deprec_cx_ecdsa_verify branch September 27, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants