Fix #1364: Error codes not systematically checked in the implementation #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
=======================================
Coverage 69.33% 69.33%
=======================================
Files 11 11
Lines 874 874
=======================================
Hits 606 606
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -71,7 +71,10 @@ cx_err_t cx_ripemd160_init_no_throw(cx_ripemd160_t *hash); | |||
| */ | |||
| static inline int cx_ripemd160_init(cx_ripemd160_t *hash) | |||
There was a problem hiding this comment.
This one should be DEPRECATED no?
There was a problem hiding this comment.
You're certainly right, but its like that on master and its not the topic of this PR, so I leave this for some volunteer ;-)
(and I just checked, it is not called today - but its not a reason to not fix it and check for other prototypes in the same case)
srasoamiaramanana-ledger
approved these changes
Oct 18, 2023
|
Let's keep in mind that these changes might cause a bunch of warnings when building apps. |
- cx_bls12381_aggregate - cx_cipher.h - ox_aes.h - ox_vss.h - cx_blake2b.h - cx_cmac.h - cx_eddsa.h - cx_hash.h - cx_pbkdf2.h - cx_poly1305.h - cx_rng_rfc6979.h - cx_rsa.h
- cx_blake2b.h - cx_sha3.h - cx_sha512.h
- lcx_aes_gcm.h - lcx_blake2.h - lcx_chacha.h - lcx_chacha_poly.h - lcx_cipher.h - lcx_cmac.h - lcx_ecdh.h - lcx_ecdsa.h - lcx_eddsa.h - lcx_groestl.h - lcx_math.h - lcx_pbkdf2.h - lcx_rsa.h - lcx_sha256.h - lcx_sha512.h
dmorais-ledger
force-pushed
the
new_1364
branch
from
e9f78c0
to
bedb954
Compare
xchapron-ledger
pushed a commit
that referenced
this pull request
Dec 5, 2023
This is an extract of #443 which includes all the changes on .h files included in lib_cxng
xchapron-ledger
pushed a commit
that referenced
this pull request
Dec 5, 2023
This is an extract of #443 which includes all the changes on .h files included in include/ox_*.h
xchapron-ledger
pushed a commit
that referenced
this pull request
Dec 5, 2023
This is an extract of #443 which includes all the changes on .h files included in lib_cxng
xchapron-ledger
pushed a commit
that referenced
this pull request
Dec 5, 2023
This is an extract of #443 which includes all the changes on .h files included in include/ox_*.h
6 tasks
xchapron-ledger
pushed a commit
that referenced
this pull request
Dec 5, 2023
This is an extract of #443 which includes all the changes on .h files included in lib_cxng
xchapron-ledger
pushed a commit
that referenced
this pull request
Dec 5, 2023
This is an extract of #443 which includes all the changes on .h files included in include/ox_*.h
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1364 about Error codes not systematically checked in the implementation
WARNING: Should be merged at the same time than corresponding PR on TTYT & bolos-ng:
https://git.donjon.ledger.fr/gitea/CI/toutouyoutest/pulls/192
https://git.donjon.ledger.fr/gitea/ledger-core/bolos-ng/pulls/2098