Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Unused arguments in lib_stusb_impl/usbd_impl.c:USBD_HID_DataOut_impl when HAVE_USB_HIDKBD macro is set #446

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[fix] Unused arguments in lib_stusb_impl/usbd_impl.c:USBD_HID_DataOut_impl when HAVE_USB_HIDKBD macro is set #446

merged 1 commit into from
Oct 11, 2023

Conversation

lpascal-ledger
Copy link
Contributor

Description

Please provide a detailed description of what was done in this PR.
(And mention any links to an issue docs)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

@lpascal-ledger lpascal-ledger force-pushed the lp/macro_warning branch 2 times, most recently from b0a86b6 to dbe0d0c Compare October 11, 2023 14:06
xchapron-ledger
xchapron-ledger reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the commit / Pr to explicit what part of the code it impact?

lib_stusb_impl/usbd_impl.c Outdated Show resolved Hide resolved
@lpascal-ledger lpascal-ledger force-pushed the lp/macro_warning branch 2 times, most recently from 1f80c19 to 2714350 Compare October 11, 2023 14:23
@lpascal-ledger lpascal-ledger changed the title [fix] Unused arguments when MACRO set [fix] Unused arguments in lib_stusb_impl/usbd_impl.c:USBD_HID_DataOut_impl when HAVE_USB_HIDKBD macro is set Oct 11, 2023
@lpascal-ledger
Copy link
Contributor Author

lpascal-ledger commented Oct 11, 2023 •
edited
Loading

codecov-action decided it could not be bothered to upload the report anymore 🤷

@xchapron-ledger
Copy link
Contributor

codecov-action decided it could not be bothered to upload the report anymore 🤷

That's sadly not unusual.

@lpascal-ledger lpascal-ledger merged commit 213f748 into master Oct 11, 2023
160 checks passed
@lpascal-ledger lpascal-ledger deleted the lp/macro_warning branch October 11, 2023 15:03
@yrichard-ledger yrichard-ledger mentioned this pull request Oct 17, 2023
Merged
This was referenced Dec 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchapron-ledger xchapron-ledger xchapron-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpascal-ledger @xchapron-ledger