Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static analysis issue #456

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

tdejoigny-ledger
Copy link
Contributor

Description

Fix static analysis issue

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd74ae3) 59.47% compared to head (27f1979) 59.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   59.47%   59.47%           
=======================================
  Files          12       12           
  Lines        1683     1683           
=======================================
  Hits         1001     1001           
  Misses        682      682           
Flag Coverage Δ
unittests 59.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.
But we have apps that have HAVE_BLE and not HAVE_IO_USB? That's probably not normal. I guess it's plugins?

@tdejoigny-ledger
Copy link
Contributor Author

Looks good for me. But we have apps that have HAVE_BLE and not HAVE_IO_USB? That's probably not normal. I guess it's plugins?

yes exactly !

@tdejoigny-ledger tdejoigny-ledger merged commit ee65eb2 into master Nov 20, 2023
160 checks passed
@tdejoigny-ledger tdejoigny-ledger deleted the tdj/fix_static_code_analysis branch November 20, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants