Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX osu build - always declare function os_setting_update() #462

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

yrichard-ledger
Copy link
Contributor

Description

Depending on the target or the on compiler version used, osu build can fail on an implicit declaration of os_setting_update(). That's because this function is declared behind HAVE_LANGUAGE_PACK flag.

This PR moves the function declaration to fix this issue

Changes include

  • [ *] Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

regardless of HAVE_LANGUAGE_PACK flag
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e54fb1b) 69.09% compared to head (e205812) 69.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files          11       11           
  Lines         877      877           
=======================================
  Hits          606      606           
  Misses        271      271           
Flag Coverage Δ
unittests 69.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrichard-ledger yrichard-ledger changed the title [FIX] osu build - always declare function os_setting_update() FIX osu build - always declare function os_setting_update() Nov 7, 2023
@yrichard-ledger yrichard-ledger merged commit 6408413 into master Nov 21, 2023
160 checks passed
@yrichard-ledger yrichard-ledger deleted the yri_fix_osu_warning branch November 21, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants