Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbgl: Add nbgl_useCaseForwardOnlyReviewNoSkip() #479

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

xchapron-ledger
Copy link
Contributor

Description

[Please provide a detailed description of what was done in this PR.
(And mention any links to an issue docs)](nbgl: Add nbgl_useCaseForwardOnlyReviewNoSkip())

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@xchapron-ledger xchapron-ledger force-pushed the xch/nbgl_useCaseForwardOnlyReviewNoSkip branch from 683f9c3 to b43ea45 Compare November 30, 2023 17:16
lib_nbgl/include/nbgl_use_case.h Outdated Show resolved Hide resolved
lib_nbgl/src/nbgl_use_case.c Outdated Show resolved Hide resolved
@xchapron-ledger xchapron-ledger force-pushed the xch/nbgl_useCaseForwardOnlyReviewNoSkip branch from b43ea45 to a3ade94 Compare December 1, 2023 09:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3f06b3) 59.44% compared to head (07d055d) 59.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   59.44%   59.44%           
=======================================
  Files          12       12           
  Lines        1684     1684           
=======================================
  Hits         1001     1001           
  Misses        683      683           
Flag Coverage Δ
unittests 59.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger force-pushed the xch/nbgl_useCaseForwardOnlyReviewNoSkip branch from a3ade94 to 07d055d Compare December 1, 2023 09:23
@xchapron-ledger xchapron-ledger force-pushed the xch/nbgl_useCaseForwardOnlyReviewNoSkip branch from 07d055d to 40d6a68 Compare December 6, 2023 16:49
@xchapron-ledger xchapron-ledger marked this pull request as ready for review December 6, 2023 16:49
@xchapron-ledger xchapron-ledger merged commit f680fa8 into master Dec 6, 2023
158 checks passed
@xchapron-ledger xchapron-ledger deleted the xch/nbgl_useCaseForwardOnlyReviewNoSkip branch December 6, 2023 16:53
@xchapron-ledger xchapron-ledger mentioned this pull request Dec 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants