Support new font sizes #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nroggeman-ledger
force-pushed
the
support-new-font-sizes
branch
from
03619e0
to
8a7a518
Compare
nroggeman-ledger
force-pushed
the
support-new-font-sizes
branch
from
8a7a518
to
5b5c8e0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 60.18% 60.42% +0.24%
==========================================
Files 12 12
Lines 1660 1660
==========================================
+ Hits 999 1003 +4
+ Misses 661 657 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nroggeman-ledger
force-pushed
the
support-new-font-sizes
branch
from
5b5c8e0
to
b43c37d
Compare
abonnaudet-ledger
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to support new font sizes (28 & 36) based on Inter Regular and Inter Semibold fonts, for later usage.
Because these sizes can be bigger, we have to change the format of internal font structures, so also the tool to generate fonts.
And instead of using directly the font names (containing the size), we will now use font alias (small, large...).
Changes include
Breaking change
Structure of fonts is mofidied so new API level is required