Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stax - Fix missing SCREEN_SIZE_WALLET flag #506

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

This PR fixes a missing SCREEN_SIZE_WALLET flag for Stax, leading to a wrong SCREEN_WIDTH when building apps, and
wrong screen building

Changes include

  • [*] Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (570aaa6) 60.42% compared to head (52a6bb4) 60.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #506   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files          12       12           
  Lines        1660     1660           
=======================================
  Hits         1003     1003           
  Misses        657      657           
Flag Coverage Δ
unittests 60.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit bb1971c into master Jan 16, 2024
161 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-missing-define-for-stax branch January 16, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants