-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nbgl shared functions #768
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nroggeman-ledger
force-pushed
the
use-nbgl-shared-function
branch
from
September 17, 2024 11:26
0b694f5
to
85f071a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 35.76% 35.49% -0.28%
==========================================
Files 13 13
Lines 1591 1606 +15
==========================================
+ Hits 569 570 +1
- Misses 1022 1036 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nroggeman-ledger
force-pushed
the
use-nbgl-shared-function
branch
from
September 17, 2024 11:49
85f071a
to
390b0db
Compare
nroggeman-ledger
force-pushed
the
use-nbgl-shared-function
branch
from
September 20, 2024 13:06
390b0db
to
d00a095
Compare
nroggeman-ledger
force-pushed
the
use-nbgl-shared-function
branch
from
October 2, 2024 06:22
d00a095
to
621b9be
Compare
nroggeman-ledger
changed the title
WIP: Use nbgl shared functions
Use nbgl shared functions
Oct 2, 2024
nroggeman-ledger
requested review from
sportron-ledger,
abonnaudet-ledger and
yrichard-ledger
October 2, 2024 08:23
nroggeman-ledger
force-pushed
the
use-nbgl-shared-function
branch
3 times, most recently
from
October 14, 2024 14:26
61b3122
to
4b94ca4
Compare
nroggeman-ledger
force-pushed
the
use-nbgl-shared-function
branch
3 times, most recently
from
October 23, 2024 09:48
f4a2c2b
to
7ed0ac1
Compare
nroggeman-ledger
force-pushed
the
use-nbgl-shared-function
branch
from
October 23, 2024 09:48
7ed0ac1
to
1cf37a5
Compare
abonnaudet-ledger
approved these changes
Oct 23, 2024
cedelavergne-ledger
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to reduce the size in Flash (and RAM) of Applications, by sharing all low-level functions of NBGL with the OS:
The architecture/Design document can be found in https://ledgerhq.atlassian.net/wiki/spaces/FW/pages/4750966807/BOLOS+Apps+-+Arch+-+NBGL+sharing+between+FW+and+Apps
Changes include
Breaking changes
For apps non using standard makefiles, there may be some risks if NBGL low-level files are compiled.
Speculos won't work. Use API LEVEL 22