Conversation
Closed
sispo3314
approved these changes
Aug 7, 2025
Collaborator
sispo3314
left a comment
There was a problem hiding this comment.
구현 내용 모두 확인했습니다!! 수고하셨어요!
상영관 선택 페이지는 왜인지 모르겠지만... 전 버전으로 되어있어서 제 PR에서 수정했습니다! 모든 기능 정상적으로 작동하는 거 확인했으니 제 PR 머지되면 pull하시거나... 복붙하시는 건 어떨까용...
soyun-git121
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 관련된 이슈
📝 작업 내용
📸 스크린샷
2025-08-07.2.15.47.mov
🚨 이슈
원래 스크롤 했을 때 다음 페이지가 요청되어야하는데 지금은 그냥 탭 클릭 시 모든 페이지가 한번에 요청되고 있긴 합니다..ㅠㅠ
📣 리뷰 요구사항
원래 무한스크롤 훅으로 분리했었는데 왜인지 모르겠으나 적용이 잘 안돼서 일단 영화관목록 페이지 내부에 무한스크롤 함수 추가해뒀습니다
일단 발표 때까지 .. 무한스크롤은 영화관 목록만 적용하는걸로 하는게 나을 것 같아요..ㅜ ㅜ
이렇게 세개에 동일하게 적용해놨습니다
✅ 체크리스트