Dns #45
Open
Dns #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #6 |
bbriggs
requested changes
Sep 1, 2017
README.md
Outdated
| @@ -62,10 +62,13 @@ The nettools Lego could be triggered by various prefix. | |||
|
|
|||
| ` !ping {target}` | |||
|
|
|||
| #### resolver | |||
| #### Resolver | |||
There was a problem hiding this comment.
The resolver implements nslookup :) i just added the host command to the package so its name changed.
There was a problem hiding this comment.
Can we alias !nslookup to the resolver class as well, then? I feel like people would try to use the tool by the name they are more familiar with.
There was a problem hiding this comment.
Yep, idk when I will have time to patch it but I will do it ASAP
setup.py
Outdated
| @@ -18,6 +18,7 @@ | |||
| install_requires=['legobot>=1.1.4,<=2.0.0', | |||
| 'python-whois', | |||
| 'urllib3', | |||
| 'dnspython', | |||
| 'bandit==1.3.0', | |||
There was a problem hiding this comment.
The libs we use for testing are not required for the module itself.
Implemented DNS lookup for A, AAAA, CNAME, MX, TXT records.
|
Rebase develop has been done and the resolver has been changed to nslookup @bbriggs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.