Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interviewfixes #77

Merged
merged 11 commits into from
Aug 3, 2023
Merged

Interviewfixes #77

merged 11 commits into from
Aug 3, 2023

Conversation

stavros-0
Copy link
Collaborator

Fixed issues #69,#70,#71,#72,#73

@stavros-0 stavros-0 requested a review from miabonardi August 2, 2023 18:24
@@ -32,6 +32,9 @@ objects:
- requestor: ALIndividual
- school: Person
---
code: |
AL_ORGANIZATION_TITLE = "Legal Services of Eastern Missouri"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "Massachusetts Advocates for Children"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be done


- al_user_bundle: ALDocumentBundle.using(elements=[initial_request_attachment, educational_evaluations_transition_assessment_request_attachment], filename="educational_evaluations_entire_record_request", title="All forms to download for your records", enabled=True)

- al_user_bundle_u13: ALDocumentBundle.using(elements=[initial_request_attachment], filename="educational_evaluations_entire_record_request", title="All forms to download for your records", enabled=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the goal here?

I dont think we should have al_user_bundle_u13 separate here.

look into using .enabled instead: https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/framework/aldocument#enabled-example

@@ -443,6 +446,35 @@ fields:
none of the above: |
I don't know.
---
id: special education director information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we removed this question for a specific reason. Why is it being added back?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this back so that the user could add an email for the special education coordinator. With the email I am able to send an email to the special education coordinator with all of the documents at the end of the interview.

@@ -683,24 +715,53 @@ event: review_initial_request
question: |
Review your answers
---
mandatory: True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this email method works. Quinten is working on adding a feature like this to the AL that is better. Lets remove it again

id: download initial_request
event: initial_request_download
question: |
All done
subquestion: |
Thank you. Your form is ready to download and deliver.
# not sure if an if statement is needed for the email to send
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this email method works. Quinten is working on adding a feature like this to the AL that is better. Lets remove it again


% else:

${ al_user_bundle_u13.download_list_html() }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below

@stavros-0 stavros-0 requested a review from miabonardi August 3, 2023 14:29
@miabonardi miabonardi merged commit ed0ff33 into main Aug 3, 2023
@miabonardi miabonardi deleted the interviewfixes branch August 7, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants