Support translations in RSS feeds #6317
Conversation
malsadev
requested review from
Nutomic,
SleeplessOne1917,
dessalines,
dullbananas and
phiresky
as code owners
| req: &HttpRequest, | ||
| context: &web::Data<LemmyContext>, | ||
| ) -> Result<Lang, Error> { | ||
| let jwt = read_auth_token(&req)?; |
There was a problem hiding this comment.
Would be good to read Accept-Language HTTP header as well for the language.
…into rss-translations-support
|
You dont need to wait for the translations to be merged. Instead do |
| }; | ||
|
|
||
| for client_lang in client_langs.ranked() { | ||
| let lang_id = match client_lang.item() { |
There was a problem hiding this comment.
| let lang_id = match client_lang.item() { | |
| match client_lang.item() | |
| .map(|l| LanguageId::new(lang.primary_language())) | |
| .map(|l| Lang::from_language_id(&lang_id)) { | |
| Some(l) => return l, | |
| None => continue, | |
| } |
No need for multiple match statements this way,
| } | ||
|
|
||
| fn negotiate_lang(req: &HttpRequest) -> Option<Lang> { | ||
| let client_langs = match req.headers().get(ACCEPT_LANGUAGE) { |
There was a problem hiding this comment.
No need for match, use req.headers().get(ACCEPT_LANGUAGE)? to return None automatically.
| .split(',') | ||
| .filter_map(|hv| hv.parse().ok()) | ||
| .collect(), | ||
| ), |
There was a problem hiding this comment.
Should work with let langs: AcceptLanguage = header.parse()? or similar.
| context: &web::Data<LemmyContext>, | ||
| ) -> Result<Lang, Error> { | ||
| let jwt = read_auth_token(&req)?; | ||
| let lang; |
There was a problem hiding this comment.
In rust you can return data from blocks.
So do
let lang = if let Some(jwt) = jwt {
...
lang
}Also what IDE are you using? I recommend using either helix or vim with rust-anaylzer, or jetbrains.
| context: &web::Data<LemmyContext>, | ||
| ) -> Result<Lang, Error> { | ||
| let jwt = read_auth_token(&req)?; | ||
| let lang; |
There was a problem hiding this comment.
In rust you can return data from blocks.
So do
let lang = if let Some(jwt) = jwt {
...
}Also what IDE are you using? I recommend using either helix or vim with rust-anaylzer, or jetbrains.
| .filter_map(|hv| hv.parse().ok()) | ||
| .collect(), | ||
| ), | ||
| None => return None, |
There was a problem hiding this comment.
Don't return from blocks like this. You should probably refactor this entire thing as an if let block:
if let Some(client_langs) = req.headers().get(ACCEPT_LANGUAGE) {
3 participants
Issue: #5365
Pipeline build is failing because this PR is dependent on: LemmyNet/lemmy-translations#246
Nortification feed testing:
Modlog feed testing:
Test fallback language: