use received_at for ingesting emails and feed generation #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This looks very good! The only thing missing is an alembic migration and this is good to merge. |
Contributor
Author
|
I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for putting this app together! I think we could make some improvements to ingesting and generating rss feeds by date
Currently the date the email was originally delivered isn't saved to Entry. This leads entries with the date the entry was created and the resulting rss feed ends up something like this:
Current Feed Order
This should help fix that by adding the date the email was originally received and sorting the rss feeds by that date
Updated Feed Order