Connecting sometimes is too quick, change some ordering logic to fix …

…that

addon/lib/driver/__init__.py

@@ -163,11 +163,12 @@ def _updateCallback_supportedSettings(
 			attribute: protocol.AttributeT,
 			settings: Iterable[DriverSetting]
 	):
+		log.debug(f"Initializing settings accessor for {len(settings)} settings")
 		self._settingsAccessor = SettingsAccessorBase.createFromSettings(self, settings) if settings else None
 		self._handleRemoteDriverChange()
 
 	def _handleRemoteDriverChange(self):
-		return
+		log.debug("Handling remote driver change")
 
 	def _get_supportedSettings(self):
 		settings = []

addon/lib/driver/settingsAccessor.py

@@ -31,16 +31,18 @@ def createFromSettings(cls, driver: "RemoteDriver", settings: Iterable[driverSet
 			dct[f"_set_{s.id}"] = cls._makeSetSetting(s.id)
 			if not isinstance(s, (driverSetting.BooleanDriverSetting, driverSetting.NumericDriverSetting)):
 				dct[f"_get_{cls._getAvailableSettingsPropertyName(s.id)}"] = cls._makeGetAvailableSettings(s.id)
+		log.debug("Constructed dictionary to generate new dynamic SettingsAccessor")
 		return type("SettingsAccessor", (SettingsAccessorBase, ), dct)(driver, settingNames)
 
 	def _get_driver(self):
 		return self._driverRef()
 
 	def __init__(self, driver: "RemoteDriver", settingNames: List[str]):
+		log.debug(f"Initializing {self} for driver {driver}, settings {settingNames}")
 		self._driverRef = weakref.ref(driver)
 		self._settingNames = settingNames
 		for name in self._settingNames:
-			self.driver.requestRemoteAttribute(self._getSettingAttributeName(name))
+			driver.requestRemoteAttribute(self._getSettingAttributeName(name))
 
 	@classmethod
 	def _getSettingAttributeName(cls, setting: str) -> protocol.AttributeT:

addon/lib/namedPipe.py

@@ -217,11 +217,11 @@ def _handleConnectCallback(self, parameter: int, timerOrWaitFired: bool):
 			raise WinError()
 		self.pipeProcessId = clientProcessId.value
 		self.pipeParentProcessId = getParentProcessId(self.pipeProcessId)
+		self._initialRead()
 		if self._onConnected is not None:
 			self._onConnected(True)
 		log.debug("End of handleConnectCallback for {self.pipeName}")
 		self._connectOl = None
-		self._initialRead()
 
 	def _onReadError(self, error: int):
 		winErr = WinError(error)
@@ -288,6 +288,19 @@ def __init__(
 		)
 		if fileHandle == INVALID_HANDLE_VALUE:
 			raise WinError()
+		try:
+			if pipeMode:
+				dwPipeMode = DWORD(pipeMode)
+				if not windll.kernel32.SetNamedPipeHandleState(fileHandle, byref(dwPipeMode), 0, 0):
+					raise WinError()
+			serverProcessId = c_ulong()
+			if not windll.kernel32.GetNamedPipeServerProcessId(HANDLE(fileHandle), byref(serverProcessId)):
+				raise WinError()
+			self.pipeProcessId = serverProcessId.value
+			self.pipeParentProcessId = getParentProcessId(self.pipeProcessId)
+		except Exception:
+			winKernel.closeHandle(fileHandle)
+			raise
 		super().__init__(
 			pipeName,
 			fileHandle,
@@ -296,15 +309,6 @@ def __init__(
 			ioThread=ioThread,
 			pipeMode=pipeMode,
 		)
-		if pipeMode:
-			dwPipeMode = DWORD(pipeMode)
-			if not windll.kernel32.SetNamedPipeHandleState(fileHandle, byref(dwPipeMode), 0, 0):
-				raise WinError()
-		serverProcessId = c_ulong()
-		if not windll.kernel32.GetNamedPipeServerProcessId(HANDLE(fileHandle), byref(serverProcessId)):
-			raise WinError()
-		self.pipeProcessId = serverProcessId.value
-		self.pipeParentProcessId = getParentProcessId(self.pipeProcessId)
 
 	def close(self):
 		super().close()

addon/lib/protocol/__init__.py

@@ -254,6 +254,7 @@ def clearCache(self):
 		self._pendingAttributeRequests.clear()
 
 	def setAttributeRequestPending(self, attribute, state: bool = True):
+		log.debug(f"Request pending for attribute {attribute!r} set to {state!r}")
 		self._pendingAttributeRequests[attribute] = state
 
 	def isAttributeRequestPending(self, attribute):
@@ -273,8 +274,8 @@ def _getDefaultValue(self, attribute: AttributeT) -> AttributeValueT:
 	def _invokeUpdateCallback(self, attribute: AttributeT, value: AttributeValueT):
 		handler = self._getRawHandler(attribute)
 		if handler._updateCallback is not None:
-			log.debug(f"Calling update callback {handler._updateCallback!r} for attribute {attribute!r}")
 			callback = handler._updateCallback.__get__(handler.__self__)
+			log.debug(f"Calling update callback {callback!r} for attribute {attribute!r}")
 			handler.__self__._bgExecutor.submit(callback, attribute, value)
 
 	def getValue(self, attribute: AttributeT, fallBackToDefault: bool = False):