feat(ring-dev-team): add 25 slash commands and notification hooks #10
Conversation
Add comprehensive slash command library organized by category: - analysis: analyze-codebase, code-searcher, diagram, directory-deep-dive, knowledger-extract - debugging: fix-problem - documentation: architecture-document, document - planning: estimate, options, question - quality: clean-comments, clean-project, code-improve, code-review, technical-debt - security: predict-issue, security-scan - utils: markdown-syntax, url-link-extractor - workflow: commit-generator, find-todos, pr-generator, prompt-engineer, summary Add context7 MCP server for documentation lookups and desktop notification hooks for tool completion events.
WalkthroughThis PR adds extensive dev-team documentation (16+ command specs across analysis, debugging, documentation, planning, quality, security, utils, and workflow), updates CLAUDE.md with expanded plugin/agent/command/skill structure and naming conventions, adds dev-team/.mcp.json (context7 MCP server), expands hooks configuration (PreToolUse and PostToolUse) in dev-team/hooks/hooks.json, and introduces a new hook implementation dev-team/hooks/notification.py that sends desktop notifications or logs events. README.md receives cosmetic formatting fixes. Sequence Diagram(s)sequenceDiagram
participant Agent as Agent / Tool
participant HookDispatcher as Hook Dispatcher
participant Notifier as dev-team/hooks/notification.py
participant Desktop as notify-send / Desktop
participant Log as ~/.claude/notifications.log
Agent->>HookDispatcher: Invoke tool (Write/Edit/Bash/Task) event
HookDispatcher->>Notifier: Run PostToolUse hook (JSON stdin)
alt notify-send available
Notifier->>Desktop: call notify-send(title, message, urgency)
Desktop-->>Notifier: success/failure
else notify-send unavailable or timeout
Notifier->>Log: append notification entry
end
Notifier-->>HookDispatcher: exit status
HookDispatcher-->>Agent: continue processing
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 15
Note
Due to the large number of review comments, Critical severity comments were prioritized as inline comments.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
316-316: Update command count to reflect 25 new dev-team commands.The line currently states Ring provides "15 slash commands" but this PR adds 25 new commands to dev-team. Consider updating to reflect the total count (40 across all plugins) or clarifying that core workflows include 15 baseline commands.
🟠 Major comments (11)
dev-team/commands/quality/clean-project.md-7-7 (1)
7-7: Use fully qualified command name.Line 7 and all usage examples should use the format
/ring-dev-team:utils:clean-project, not/shared:utils:clean-project, to comply with the coding guideline for fully qualified command names.As per coding guidelines, apply this diff to Lines 7 and 91+:
-# /shared:utils:clean-project +# /ring-dev-team:utils:clean-projectAnd update example usages:
-/shared:utils:clean-project --git-scope=all +/ring-dev-team:utils:clean-project --git-scope=allAlso applies to: 91-107
dev-team/commands/documentation/architecture-document.md-6-6 (1)
6-6: Use fully qualified command name.Line 6 should use the format
/ring-dev-team:documentation:architecture-document, not/shared:documentation:architecture-document, to comply with the fully qualified command naming guideline.Apply this diff:
-# /shared:documentation:architecture-document +# /ring-dev-team:documentation:architecture-documentdev-team/commands/utils/markdown-syntax.md-7-7 (1)
7-7: Use fully qualified command name.Line 7 and all usage examples should use
/ring-dev-team:utils:markdown-syntax, not/shared:utils:markdown-syntax, to comply with the fully qualified command naming guideline.Apply this diff:
-# /shared:utils:markdown-syntax +# /ring-dev-team:utils:markdown-syntaxAnd update example usages at Lines 15–17:
-/shared:utils:markdown-syntax --input=path/to/file.md +/ring-dev-team:utils:markdown-syntax --input=path/to/file.mdAlso applies to: 15-17
dev-team/commands/quality/clean-comments.md-7-7 (1)
7-7: Use fully qualified command names per coding guidelines.Command invocation names must use the format
ring-{plugin}:{category}:{component}to prevent ambiguity in multi-plugin environments. Line 7 should be/ring-dev-team:quality:clean-comments, and all command references throughout the file (lines 17, 20, 23, 82) should use fully qualified names like/ring-dev-team:analysis:analyze-codebaseand/ring-dev-team:quality:clean-comments.File
security-scan.mdin this PR correctly uses this format; this file should follow the same pattern for consistency.As per coding guidelines, apply this diff to Line 7:
-# /shared:code-quality:clean-comments +# /ring-dev-team:quality:clean-commentsAnd update all command references throughout, for example:
-/documentation:analyze-codebase +/ring-dev-team:analysis:analyze-codebase -/code-quality:clean-comments +/ring-dev-team:quality:clean-commentsAlso applies to: 17-23, 57-106
dev-team/commands/analysis/code-searcher.md-7-7 (1)
7-7: Use fully qualified command name and fix code fence language.Line 7 should use the format
ring-{plugin}:{category}:{component}. Since this file is indev-team/commands/analysis/, the command should be/ring-dev-team:analysis:code-searcher, not/shared:documentation:code-searcher.Additionally, the fenced code block at Line 125 is missing a language specifier.
Apply this diff:
-# /shared:documentation:code-searcher +# /ring-dev-team:analysis:code-searcherAnd add a language tag to Line 125:
-``` +```textAlso applies to: 11-11
dev-team/commands/workflow/find-todos.md-7-7 (1)
7-7: Use fully qualified command name with plugin and category.Line 7 and all usage examples must use the fully qualified format. Since this file is in
dev-team/commands/workflow/, the command should be/ring-dev-team:workflow:find-todos, not/shared:find-todos.Apply this diff:
-# /shared:find-todos +# /ring-dev-team:workflow:find-todosAnd update example usages:
-/shared:find-todos --git-scope=all-changes +/ring-dev-team:workflow:find-todos --git-scope=all-changesAlso applies to: 19-26
dev-team/commands/security/predict-issue.md-6-6 (1)
6-6: Use fully qualified command name with category.Line 6 should use the fully qualified format
ring-{plugin}:{category}:{command}. Since this file is indev-team/commands/security/, it should be/ring-dev-team:security:predict-issue, not/shared:predict-issue.Apply this diff:
-# /shared:predict-issue +# /ring-dev-team:security:predict-issuedev-team/commands/workflow/commit-generator.md-24-24 (1)
24-24: Fix remaining command invocations.Additional command invocations also need correction.
# Basic usage (defaults to staged changes) -/ring-dev-team:workflow:commit-generator +/ring-dev-team:commit-generator```bash -/ring-dev-team:workflow:commit-generator +/ring-dev-team:commit-generator```diff ```bash -/ring-dev-team:workflow:commit-generator --git-scope=branch +/ring-dev-team:commit-generator --git-scope=branchAlso applies to: 103-103, 119-119 </blockquote></details> <details> <summary>dev-team/commands/workflow/pr-generator.md-7-7 (1)</summary><blockquote> `7-7`: **Fix command name and plugin reference.** The heading uses "PR Generator" without the proper command invocation format. Based on the file location (`dev-team/commands/workflow/pr-generator.md`) and coding guidelines, this should be `/ring-dev-team:pr-generator`. ```diff -# PR Generator +# /ring-dev-team:pr-generatordev-team/commands/workflow/commit-generator.md-17-21 (1)
17-21: Update all usage examples to use correct command format.All usage examples reference
/ring-dev-team:workflow:commit-generatorbut should use/ring-dev-team:commit-generator(without theworkflowcategory).Apply this diff to fix the examples:
# Analyze different sets of changes -/ring-dev-team:workflow:commit-generator --git-scope=staged # Generate message for staged changes only (default) -/ring-dev-team:workflow:commit-generator --git-scope=all-changes # Generate message for all changes (staged + unstaged) -/ring-dev-team:workflow:commit-generator --git-scope=unstaged # Generate message for unstaged changes only -/ring-dev-team:workflow:commit-generator --git-scope=branch # Generate message for branch changes -/ring-dev-team:workflow:commit-generator --git-scope=last-commit # Generate message based on last commit +/ring-dev-team:commit-generator --git-scope=staged # Generate message for staged changes only (default) +/ring-dev-team:commit-generator --git-scope=all-changes # Generate message for all changes (staged + unstaged) +/ring-dev-team:commit-generator --git-scope=unstaged # Generate message for unstaged changes only +/ring-dev-team:commit-generator --git-scope=branch # Generate message for branch changes +/ring-dev-team:commit-generator --git-scope=last-commit # Generate message based on last commitCommittable suggestion skipped: line range outside the PR's diff.
dev-team/commands/workflow/commit-generator.md-7-7 (1)
7-7: Remove category segment from all command invocations to match coding guidelines.Commands should use
/ring-dev-team:{command}format, not/ring-dev-team:{category}:{command}. The category is part of the filesystem organization but should not appear in the invocation name. This applies to all instances in the file:-# /ring-dev-team:workflow:commit-generator +# /ring-dev-team:commit-generatorAnd all usage examples:
-/ring-dev-team:workflow:commit-generator --git-scope=staged +/ring-dev-team:commit-generator --git-scope=stagedNote: This issue systematically affects 5 dev-team command files (analyze-codebase, directory-deep-dive, code-review, security-scan, commit-generator) which all incorrectly use the three-part format. All should follow the standard two-part format established by other plugins like
/ring-default:brainstormand/ring-pm-team:pre-dev-feature.
🟡 Minor comments (1)
dev-team/hooks/notification.py-1-1 (1)
1-1: Make the script executable.The file has a shebang but is not marked as executable. Hook scripts referenced in
hooks.jsonneed execute permissions.Run this command to fix:
#!/bin/bash chmod +x dev-team/hooks/notification.py
🧹 Nitpick comments (11)
README.md (1)
199-199: Add language specification to fenced code blocks.Lines 199 and 207 have fenced code blocks without language identifiers. Per static analysis (MD040), specify the language for syntax highlighting:
-``` +```bash Before ANY action → Check skillsAlso applies to: 207-207
dev-team/commands/planning/question.md (1)
9-20: Remove duplicate "Context" heading.Lines 9 and 20 both use the heading "## Context", which violates MD024 (no-duplicate-heading). The first instance on line 9 appears to be descriptive context, while line 20 introduces the workflow context. Rename one to clarify intent:
## Instructions ... -## Context +## About This Command Answer questions about the project structure... -## Context +## Workflowdev-team/commands/analysis/diagram.md (1)
89-89: Add language specification to code block.Line 89 has a fenced code block without a language identifier. Per MD040, add the language for syntax highlighting:
-``` +```bash # Analyze project structuredev-team/commands/quality/code-review.md (1)
26-26: Minor rewording for clarity at context description.The phrase "without making changes to the codebase" is slightly wordy and could be simplified to "without modifying code" for a stronger statement.
dev-team/commands/quality/technical-debt.md (2)
29-29: Add language specifier to fenced code blocks.Fenced code blocks on lines 29 and 52 (and line 375 bash block) should specify a language for syntax highlighting:
-``` +```bashAlso applies to: 52-52
345-345: Convert emphasis-based section headers to proper markdown headings.Lines 345, 352, 359, 366 use emphasis (
**text**) instead of heading syntax. Use###for consistency:-**Critical (Fix Immediately)** +### Critical (Fix Immediately) -**High (Next Sprint)** +### High (Next Sprint) -**Medium (Next Quarter)** +### Medium (Next Quarter) -**Low (Backlog)** +### Low (Backlog)Also applies to: 352-352, 359-359, 366-366
dev-team/commands/planning/options.md (1)
98-98: Add language specifier to fenced code block.Line 98 fenced code block should specify language:
-``` +```bashdev-team/commands/documentation/document.md (1)
49-49: Fix grammar: "etc." requires a period in American English.Lines 49 and 157 use "etc" without period. American English style requires "etc."
-security, etc +security, etc. -README missing, etc) +README missing, etc.)Also applies to: 157-157
dev-team/commands/analysis/knowledger-extract.md (1)
305-305: Fix grammar: Use hyphen to join compound adjective.Line 305 should use hyphen: "knowledge-sharing practices"
-knowledge sharing practices +knowledge-sharing practicesdev-team/hooks/hooks.json (1)
24-34: Extract Python one-liner into a separate script file for maintainability.The inline Python command at line 30 is ~400 characters long and implements complex logic (JSON parsing, regex matching, temporal keyword detection, query modification). This makes it difficult to read, test, debug, and maintain.
Consider extracting this logic into a separate script file:
Create
dev-team/hooks/web-search-augment.py:#!/usr/bin/env python3 """Augment WebSearch queries with current year when appropriate.""" import json import sys import re from datetime import datetime def main(): input_data = json.load(sys.stdin) tool_input = input_data.get('tool_input', {}) query = tool_input.get('query', '') current_year = str(datetime.now().year) has_year = re.search(r'\b20\d{2}\b', query) has_temporal = any(word in query.lower() for word in ['latest', 'recent', 'current', 'new', 'now', 'today']) should_add_year = not has_year and not has_temporal modified_query = f'{query} {current_year}' if should_add_year else query output = { 'hookSpecificOutput': { 'hookEventName': 'PreToolUse', 'modifiedToolInput': {'query': modified_query} } } print(json.dumps(output)) sys.exit(0) if __name__ == "__main__": main()Then update the hook configuration:
{ "matcher": "WebSearch", "hooks": [ { "type": "command", - "command": "python3 -c \"import json, sys, re; from datetime import datetime; input_data = json.load(sys.stdin); tool_input = input_data.get('tool_input', {}); query = tool_input.get('query', ''); current_year = str(datetime.now().year); has_year = re.search(r'\\\\b20\\\\d{2}\\\\b', query); has_temporal = any(word in query.lower() for word in ['latest', 'recent', 'current', 'new', 'now', 'today']); should_add_year = not has_year and not has_temporal; modified_query = f'{query} {current_year}' if should_add_year else query; output = {'hookSpecificOutput': {'hookEventName': 'PreToolUse', 'modifiedToolInput': {'query': modified_query}}}; print(json.dumps(output)); sys.exit(0)\"", + "command": "${CLAUDE_PLUGIN_ROOT}/hooks/web-search-augment.py", "timeout": 5 } ] }Benefits:
- Easier to read and understand
- Can be tested independently
- Simpler debugging
- Better error handling
- Consistent with notification.py approach
dev-team/commands/workflow/prompt-engineer.md (1)
90-92: Add language identifier to fenced code block.The fenced code block should specify a language identifier for proper syntax highlighting and processing.
-``` +```text [Complete prompt text will be displayed here in a code block]</blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used**: CodeRabbit UI **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 887e1b5d86ea5dc96fa8148691b8675b25e3beee and 1bf3bf55d63602df96b556e2d211c758bc9311dc. </details> <details> <summary>📒 Files selected for processing (30)</summary> * `CLAUDE.md` (18 hunks) * `README.md` (27 hunks) * `dev-team/.mcp.json` (1 hunks) * `dev-team/commands/analysis/analyze-codebase.md` (1 hunks) * `dev-team/commands/analysis/code-searcher.md` (1 hunks) * `dev-team/commands/analysis/diagram.md` (1 hunks) * `dev-team/commands/analysis/directory-deep-dive.md` (1 hunks) * `dev-team/commands/analysis/knowledger-extract.md` (1 hunks) * `dev-team/commands/debugging/fix-problem.md` (1 hunks) * `dev-team/commands/documentation/architecture-document.md` (1 hunks) * `dev-team/commands/documentation/document.md` (1 hunks) * `dev-team/commands/planning/estimate.md` (1 hunks) * `dev-team/commands/planning/options.md` (1 hunks) * `dev-team/commands/planning/question.md` (1 hunks) * `dev-team/commands/quality/clean-comments.md` (1 hunks) * `dev-team/commands/quality/clean-project.md` (1 hunks) * `dev-team/commands/quality/code-improve.md` (1 hunks) * `dev-team/commands/quality/code-review.md` (1 hunks) * `dev-team/commands/quality/technical-debt.md` (1 hunks) * `dev-team/commands/security/predict-issue.md` (1 hunks) * `dev-team/commands/security/security-scan.md` (1 hunks) * `dev-team/commands/utils/markdown-syntax.md` (1 hunks) * `dev-team/commands/utils/url-link-extractor.md` (1 hunks) * `dev-team/commands/workflow/commit-generator.md` (1 hunks) * `dev-team/commands/workflow/find-todos.md` (1 hunks) * `dev-team/commands/workflow/pr-generator.md` (1 hunks) * `dev-team/commands/workflow/prompt-engineer.md` (1 hunks) * `dev-team/commands/workflow/summary.md` (1 hunks) * `dev-team/hooks/hooks.json` (1 hunks) * `dev-team/hooks/notification.py` (1 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>📓 Path-based instructions (2)</summary> <details> <summary>**/*.{md,sh,json}</summary> **📄 CodeRabbit inference engine (CLAUDE.md)** > Always use fully qualified agent/skill/command invocation names in the format 'ring-{plugin}:{component-name}' to prevent ambiguity in multi-plugin environments Files: - `dev-team/commands/quality/clean-comments.md` - `dev-team/commands/debugging/fix-problem.md` - `dev-team/commands/quality/code-improve.md` - `dev-team/commands/workflow/prompt-engineer.md` - `dev-team/commands/analysis/code-searcher.md` - `dev-team/commands/planning/options.md` - `dev-team/commands/documentation/document.md` - `dev-team/commands/workflow/find-todos.md` - `dev-team/commands/utils/url-link-extractor.md` - `dev-team/commands/workflow/pr-generator.md` - `README.md` - `dev-team/commands/documentation/architecture-document.md` - `dev-team/hooks/hooks.json` - `dev-team/commands/analysis/analyze-codebase.md` - `dev-team/commands/analysis/directory-deep-dive.md` - `dev-team/commands/planning/estimate.md` - `dev-team/commands/workflow/summary.md` - `dev-team/commands/utils/markdown-syntax.md` - `dev-team/commands/security/security-scan.md` - `dev-team/commands/security/predict-issue.md` - `dev-team/commands/quality/clean-project.md` - `dev-team/commands/quality/technical-debt.md` - `CLAUDE.md` - `dev-team/commands/analysis/diagram.md` - `dev-team/commands/planning/question.md` - `dev-team/commands/analysis/knowledger-extract.md` - `dev-team/commands/workflow/commit-generator.md` - `dev-team/commands/quality/code-review.md` </details> <details> <summary>CLAUDE.md</summary> **📄 CodeRabbit inference engine (AGENTS.md)** > Extract guidelines from CLAUDE.md file Files: - `CLAUDE.md` </details> </details><details> <summary>🧠 Learnings (27)</summary> <details> <summary>📓 Common learnings</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: When modifying agents, skills, commands, or hooks, ensure consistency across CLAUDE.md, MANUAL.md, README.md, ARCHITECTURE.md, plugin hooks, and using-* skills; search repository for old names if renaming</details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to */agents/{backend-engineer,devops-engineer,sre,qa-analyst,frontend-engineer,finops-automation}.md : For backend engineers: divide implementations into Summary, Implementation, Files Changed, Testing, and Next Steps sections. For designers and finops: use Analysis, Findings, Recommendations, and Next Steps sections.**Applied to files:** - `dev-team/commands/debugging/fix-problem.md` - `dev-team/commands/workflow/prompt-engineer.md` - `dev-team/commands/analysis/code-searcher.md` - `dev-team/commands/workflow/pr-generator.md` - `README.md` - `dev-team/commands/documentation/architecture-document.md` - `dev-team/commands/analysis/analyze-codebase.md` - `dev-team/commands/analysis/directory-deep-dive.md` - `dev-team/commands/planning/estimate.md` - `dev-team/commands/quality/technical-debt.md` - `CLAUDE.md` - `dev-team/commands/analysis/knowledger-extract.md` - `dev-team/commands/quality/code-review.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/agents/{code-reviewer,business-logic-reviewer,security-reviewer}.md : Code review agents must produce output with VERDICT (PASS|FAIL|NEEDS_DISCUSSION), Summary, Issues Found, Categorized Issues (Critical/High/Medium/Low), What Was Done Well, and Next Steps sections**Applied to files:** - `dev-team/commands/analysis/code-searcher.md` - `dev-team/commands/workflow/pr-generator.md` - `README.md` - `CLAUDE.md` - `dev-team/commands/quality/code-review.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/skills/pre-dev-/SKILL.md : Pre-dev workflow gates must produce documented artifacts in docs/pre-dev/{feature}/.md following the sequence: Research → PRD → TRD → API → Data → Tasks (for full 9-gate workflow)**Applied to files:** - `dev-team/commands/workflow/pr-generator.md` - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-11-25T22:38:59.828Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T22:38:59.828Z
Learning: Applies to **/agents/*-reviewer.md : Agent files must follow the {domain}-reviewer.md naming convention**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-11-25T22:38:59.828Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T22:38:59.828Z
Learning: Applies to /agents/-reviewer.md : Review agents must include output_schema definition and be referenced in the requesting-code-review skill**Applied to files:** - `README.md` - `CLAUDE.md` - `dev-team/commands/quality/code-review.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to tw-team/agents/*.md : Technical writing agents must produce: Functional Writer for guides/tutorials/conceptual docs, API Writer for API reference documentation, Docs Reviewer for quality review with standardized voice and tone**Applied to files:** - `README.md` - `CLAUDE.md` - `dev-team/commands/quality/code-review.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/agents/*.md : Agent output must follow the appropriate schema (Implementation, Analysis, Reviewer, Exploration, or Planning) with all required_sections validated against their regex patterns**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/*.{md,sh,json} : Always use fully qualified agent/skill/command invocation names in the format 'ring-{plugin}:{component-name}' to prevent ambiguity in multi-plugin environments**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to {/skills/*,/agents/.md,**/commands/.md,**/hooks/*.sh} : Use kebab-case for skill directory names and filenames, {domain}-reviewer.md format for agents, /ring-{plugin}:{action} format for commands, {event}-{purpose}.sh format for hooks**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to {**/skills/using-*/SKILL.md,.claude-plugin/marketplace.json} : Each plugin must have a using-{plugin} skill that is auto-loaded at SessionStart to introduce available agents and capabilities; plugin versions must be registered in .claude-plugin/marketplace.json**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: When modifying agents, skills, commands, or hooks, ensure consistency across CLAUDE.md, MANUAL.md, README.md, ARCHITECTURE.md, plugin hooks, and using-* skills; search repository for old names if renaming**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-11-25T22:38:59.828Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T22:38:59.828Z
Learning: Applies to .claude-plugin/marketplace.json : Plugin configuration must be defined in marketplace.json with name, description, version, and source fields**Applied to files:** - `README.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Never skip the using-ring skill (mandatory workflow), never run reviewers sequentially, never modify auto-generated skill references, never skip TDD's RED phase, never commit incomplete code, never use panic() in Go**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/*.{test,spec}.{js,ts,go,py} : In TDD workflow, test file must exist before implementation, test must produce failure output (RED phase), and only then write implementation (GREEN phase)**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/skills/using-ring/SKILL.md : All skill invocations must announce non-obvious skill usage and check for applicable skills before any task**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to finops-team/**/*.md : For Brazilian regulatory compliance (FinOps), use BACEN and RFB regulatory templates with finops-analyzer for compliance analysis and finops-automation for template generation**Applied to files:** - `README.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to {/skills/*/SKILL.md,/hooks/session-start.sh} : Use markdown-based skill definitions with YAML frontmatter that are auto-discovered at session start via hooks and executed through Claude Code's native Skill/Task tools**Applied to files:** - `README.md` - `dev-team/hooks/hooks.json` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-03T19:09:48.358Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-03T19:09:48.358Z
Learning: Applies to CLAUDE.md : Extract guidelines from CLAUDE.md file**Applied to files:** - `README.md` - `dev-team/commands/planning/estimate.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: For code review agents, use parallel Task execution (single message with multiple tool calls) rather than sequential execution to optimize review time from ~60 minutes to ~20 minutes**Applied to files:** - `README.md` - `CLAUDE.md` - `dev-team/commands/quality/code-review.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/skills/*/SKILL.md : Create skill directories with kebab-case names and include SKILL.md with YAML frontmatter containing name, description, trigger, skip_when, sequence, and related metadata**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-11-25T22:38:59.828Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T22:38:59.828Z
Learning: Applies to **/skills/*/SKILL.md : Skills must be defined with YAML frontmatter including name, description, and when_to_use fields in SKILL.md files**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-11-25T22:38:59.828Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T22:38:59.828Z
Learning: Applies to **/skills/*/ : Skill directories must use kebab-case naming convention matching the directory name**Applied to files:** - `README.md` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-11-25T22:38:59.828Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T22:38:59.828Z
Learning: All applicable skills must be used for tasks; 'simple task' is not an excuse to skip skill usage**Applied to files:** - `README.md` </details> <details> <summary>📚 Learning: 2025-11-25T22:38:59.828Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T22:38:59.828Z
Learning: Applies to **/hooks/hooks.json : Session hooks must run on startup|resume and clear|compact events as configured in hooks.json**Applied to files:** - `dev-team/hooks/hooks.json` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/hooks/*.sh : Hook scripts must output JSON with success/error fields; SessionStart hooks run on 'startup|resume' and 'clear|compact' events; use '${CLAUDE_PLUGIN_ROOT}' variable for plugin root resolution**Applied to files:** - `dev-team/hooks/hooks.json` - `dev-team/hooks/notification.py` - `CLAUDE.md` </details> <details> <summary>📚 Learning: 2025-12-04T13:04:35.163Z</summary>Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Always use /ring-default:commit command for all commits with --trailer parameter for AI identification (never use HEREDOC for trailers in message body); enforce conventional commits format**Applied to files:** - `dev-team/commands/workflow/commit-generator.md` </details> </details><details> <summary>🪛 LanguageTool</summary> <details> <summary>dev-team/commands/quality/clean-comments.md</summary> [style] ~42-~42: The words ‘explain’ and ‘explanation’ are quite similar. Consider replacing ‘explain’ with a different word. Context: ... Code Comment Rules 1. **Always try to explain yourself in code** - Remove comments th... (VERB_NOUN_SENT_LEVEL_REP) --- [style] ~47-~47: The words ‘explanation’ and ‘explaining’ are quite similar. Consider replacing ‘explaining’ with a different word. Context: ...anation of intent** - Preserve comments explaining WHY, not WHAT 7. **Keep warnings of con... (VERB_NOUN_SENT_LEVEL_REP) --- [style] ~48-~48: Try using a synonym here to strengthen your wording. Context: ...p warnings of consequences** - Preserve comments about important side effects 8. **Keep ... (COMMENT_REMARK) </details> <details> <summary>dev-team/commands/documentation/document.md</summary> [style] ~49-~49: In American English, abbreviations like “etc.” require a period. Context: ...hitecture, bugs, performance, security, etc 4. **Update EVERYTHING affected** - Not... (ETC_PERIOD) --- [style] ~157-~157: ‘absolutely essential’ might be wordy. Consider a shorter alternative. Context: ...nd formatting - Only create new docs if absolutely essential (README missing, etc) **Preserve secti... (EN_WORDINESS_PREMIUM_ABSOLUTELY_ESSENTIAL) --- [style] ~157-~157: In American English, abbreviations like “etc.” require a period. Context: ...f absolutely essential (README missing, etc) **Preserve sections:** ```markdown <... (ETC_PERIOD) </details> <details> <summary>dev-team/commands/utils/url-link-extractor.md</summary> [style] ~11-~11: Consider a different adjective to strengthen your wording. Context: ...URL and link extraction specialist with deep knowledge of web development patterns a... (DEEP_PROFOUND) --- [uncategorized] ~74-~74: Did you mean the formatting language “Markdown” (= proper noun)? Context: ...ured inventory in clear format (JSON or markdown table) - Include statistics (total URLs... (MARKDOWN_NNP) --- [uncategorized] ~92-~92: Did you mean the formatting language “Markdown” (= proper noun)? Context: ...ructured format**: Inventory in JSON or markdown table format - **Context**: File path a... (MARKDOWN_NNP) </details> <details> <summary>dev-team/commands/utils/markdown-syntax.md</summary> [uncategorized] ~11-~11: Did you mean the formatting language “Markdown” (= proper noun)? Context: ...syntax ## Instructions Format text in markdown syntax or identify and fix issues in ex... (MARKDOWN_NNP) --- [style] ~11-~11: Consider using a different verb for a more formal wording. Context: ...text in markdown syntax or identify and fix issues in existing markdown files. Enfo... (FIX_RESOLVE) --- [uncategorized] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)? Context: ...ile path, read the file and analyze its markdown syntax. - If input is text content,... (MARKDOWN_NNP) --- [uncategorized] ~53-~53: Did you mean the formatting language “Markdown” (= proper noun)? Context: ...ut modifying the file. - Verify all markdown syntax is valid and follows standard co... (MARKDOWN_NNP) --- [uncategorized] ~117-~117: Did you mean the formatting language “Markdown” (= proper noun)? Context: ...pdate the specified file with compliant markdown syntax - Or, display the properly forma... (MARKDOWN_NNP) --- [uncategorized] ~118-~118: Did you mean the formatting language “Markdown” (= proper noun)? Context: ...ax - Or, display the properly formatted markdown text for manual use - Report the compre... (MARKDOWN_NNP) --- [uncategorized] ~130-~130: Did you mean the formatting language “Markdown” (= proper noun)? Context: ...ighting 5. Links and images use correct markdown syntax 6. Document structure is logical... (MARKDOWN_NNP) </details> <details> <summary>dev-team/commands/security/security-scan.md</summary> [uncategorized] ~37-~37: The official name of this software platform is spelled with a capital “H”. Context: ....env\* (if exists) - Security config: @.github/workflows/security.yml or @security/ (i... (GITHUB) </details> <details> <summary>dev-team/commands/quality/clean-project.md</summary> [grammar] ~43-~43: Use a hyphen to join words. Context: ...- Group similar files for batch decision making - **Git-aware**: Focus on arti... (QB_NEW_EN_HYPHEN) </details> <details> <summary>dev-team/commands/quality/technical-debt.md</summary> [grammar] ~495-~495: Use a hyphen to join words. Context: ...Metrics:** - Reduction in critical/high priority debt items - Improvement in cod... (QB_NEW_EN_HYPHEN) </details> <details> <summary>dev-team/commands/analysis/knowledger-extract.md</summary> [grammar] ~305-~305: Use a hyphen to join words. Context: ...elopment workflows - Establish knowledge sharing practices ### Maintenance Strat... (QB_NEW_EN_HYPHEN) </details> <details> <summary>dev-team/commands/workflow/commit-generator.md</summary> [grammar] ~88-~88: Use a hyphen to join words. Context: ...x:** A bug fix - **docs:** Documentation only changes - **style:** Changes that d... (QB_NEW_EN_HYPHEN) </details> <details> <summary>dev-team/commands/quality/code-review.md</summary> [style] ~26-~26: Consider shortening or rephrasing this to strengthen your wording. Context: ..., and improvement opportunities without making changes to the codebase. ## Usage Examples ```ba... (MAKE_CHANGES) </details> </details> <details> <summary>🪛 markdownlint-cli2 (0.18.1)</summary> <details> <summary>dev-team/commands/debugging/fix-problem.md</summary> 336-336: Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> <details> <summary>dev-team/commands/workflow/prompt-engineer.md</summary> 90-90: Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> <details> <summary>dev-team/commands/analysis/code-searcher.md</summary> 125-125: Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> <details> <summary>dev-team/commands/planning/options.md</summary> 98-98: Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> <details> <summary>README.md</summary> 199-199: Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 207-207: Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> <details> <summary>dev-team/commands/analysis/directory-deep-dive.md</summary> 20-20: Multiple headings with the same content (MD024, no-duplicate-heading) </details> <details> <summary>dev-team/commands/quality/clean-project.md</summary> 40-40: Spaces inside emphasis markers (MD037, no-space-in-emphasis) </details> <details> <summary>dev-team/commands/quality/technical-debt.md</summary> 29-29: Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 52-52: Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 345-345: Emphasis used instead of a heading (MD036, no-emphasis-as-heading) --- 352-352: Emphasis used instead of a heading (MD036, no-emphasis-as-heading) --- 359-359: Emphasis used instead of a heading (MD036, no-emphasis-as-heading) --- 366-366: Emphasis used instead of a heading (MD036, no-emphasis-as-heading) </details> <details> <summary>dev-team/commands/analysis/diagram.md</summary> 89-89: Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 109-109: Tables should be surrounded by blank lines (MD058, blanks-around-tables) </details> <details> <summary>dev-team/commands/planning/question.md</summary> 20-20: Multiple headings with the same content (MD024, no-duplicate-heading) </details> </details> <details> <summary>🪛 Ruff (0.14.7)</summary> <details> <summary>dev-team/hooks/notification.py</summary> 1-1: Shebang is present but file is not executable (EXE001) --- 16-16: `subprocess` call: check for execution of untrusted input (S603) --- 17-27: Starting a process with a partial executable path (S607) </details> </details> </details> <details> <summary>🔇 Additional comments (15)</summary><blockquote> <details> <summary>README.md (1)</summary><blockquote> `437-464`: **Verify dev-team command documentation references use fully qualified names.** The dev-team architecture section (lines 437–464) correctly shows command categories. Ensure all 25 command files use the fully qualified format `ring-dev-team:{category}:{command}` in their markdown headers and throughout documentation to maintain consistency with the coding guidelines and naming conventions established across CLAUDE.md, MANUAL.md, and other reference docs. Based on learnings, ensure consistency across CLAUDE.md, MANUAL.md, README.md, ARCHITECTURE.md, plugin hooks, and using-* skills when referencing agents/commands. [coding_guidelines] </blockquote></details> <details> <summary>dev-team/.mcp.json (1)</summary><blockquote> `1-8`: **LGTM!** The MCP server configuration is properly structured and aligns with the documentation enhancement goals. No concerns. </blockquote></details> <details> <summary>dev-team/commands/analysis/analyze-codebase.md (1)</summary><blockquote> `1-175`: **LGTM!** Command naming follows the fully qualified format correctly (`ring-dev-team:analysis:analyze-codebase`), and documentation is well-structured with clear phases and deliverables. This file serves as a good template for consistency across the dev-team command suite. </blockquote></details> <details> <summary>dev-team/commands/analysis/directory-deep-dive.md (1)</summary><blockquote> `1-145`: **LGTM! Command naming is correct.** The command uses the fully qualified format correctly (`ring-dev-team:analysis:directory-deep-dive`) and documentation is comprehensive with clear investigation phases and report structure. </blockquote></details> <details> <summary>dev-team/commands/analysis/diagram.md (1)</summary><blockquote> `7-7`: **Clarify command naming—verify if this should be dev-team:analysis or truly a shared command.** Line 7 shows `/shared:documentation:diagram`, but the file path is `dev-team/commands/analysis/diagram.md`. This creates ambiguity: - If this is a dev-team plugin command, it should be `/ring-dev-team:analysis:diagram` - If it's meant to be shared across plugins, the file should be moved to a shared commands directory Please clarify the intended scope and update the header accordingly. </blockquote></details> <details> <summary>dev-team/commands/security/security-scan.md (1)</summary><blockquote> `7-7`: **Exemplary command naming compliance.** This file correctly uses fully qualified command names throughout (e.g., `/ring-dev-team:security:security-scan`). This is the correct pattern that should be followed by all other command documentation files in this PR for consistency. Also applies to: 15-24 </blockquote></details> <details> <summary>dev-team/commands/quality/code-review.md (1)</summary><blockquote> `7-7`: **✅ Correct namespace format and consistent usage throughout.** File uses the fully qualified command name `/ring-dev-team:quality:code-review` correctly in the header and all usage examples. This follows the coding guidelines for multi-plugin environments. Also applies to: 32-45 </blockquote></details> <details> <summary>dev-team/commands/planning/options.md (1)</summary><blockquote> `7-7`: **🔴 Critical: Incomplete and incorrect namespace – must use `ring-dev-team:planning:options` format.** Current namespace `/shared:options` violates two aspects of the coding guidelines: 1. Uses `/shared:` instead of `/ring-dev-team:` 2. Missing category segment (should include `planning`) Correct format per guidelines and code-review.md pattern: `/ring-dev-team:planning:options` This appears on line 7 and in the usage example at line 16. Apply these diffs: ```diff -# /shared:options +# /ring-dev-team:planning:options-/shared:options --task="<task-or-problem-description>" +/ring-dev-team:planning:options --task="<task-or-problem-description>"Also applies to: 16-16
⛔ Skipped due to learnings
Learnt from: CR Repo: LerianStudio/ring PR: 0 File: CLAUDE.md:0-0 Timestamp: 2025-12-04T13:04:35.163Z Learning: Applies to {**/skills/*,**/agents/*.md,**/commands/*.md,**/hooks/*.sh} : Use kebab-case for skill directory names and filenames, {domain}-reviewer.md format for agents, /ring-{plugin}:{action} format for commands, {event}-{purpose}.sh format for hooksdev-team/hooks/hooks.json (1)
2-2: LGTM! Clear description of hook functionality.The description clearly states the purpose of the hooks configuration.
dev-team/hooks/notification.py (2)
14-36: LGTM! Graceful fallback for notification failures.The notification function properly handles failures (timeout, missing notify-send) by logging to a fallback file rather than breaking the hook execution.
53-99: Well-structured event handling logic.The PostToolUse event handling is cleanly organized by tool type (Write/Edit/MultiEdit, Bash, Task) with appropriate message formatting and urgency levels.
CLAUDE.md (4)
11-12: LGTM! Accurate plugin description.The updated description correctly reflects the dev-team plugin composition (2 skills, 25 commands, 10 agents, hooks, and MCP servers).
128-161: Well-organized command documentation structure.The command categories (analysis, debugging, documentation, planning, quality, security, utils, workflow) are clearly organized and comprehensive. This makes it easy for users to discover and understand available commands.
163-166: LGTM! Accurate hooks documentation.The hooks section correctly documents the new PreToolUse and PostToolUse contexts, including the notification.py script addition.
30-35: Clear platform support table.The updated table clearly shows supported platforms with their install paths, formats, and component types.
| /shared:development:pr-generator | ||
| ``` |
There was a problem hiding this comment.
Fix remaining command invocations in examples.
Additional occurrences of the incorrect command format need to be corrected.
```bash
-/shared:development:pr-generator
+/ring-dev-team:pr-generator
```diff
```bash
-/shared:development:pr-generator --title="Fix authentication timeout issue" --issue=789
+/ring-dev-team:pr-generator --title="Fix authentication timeout issue" --issue=789
Also applies to: 181-181
<details>
<summary>🤖 Prompt for AI Agents</summary>
In dev-team/commands/workflow/pr-generator.md around lines 140-141 (and also at
line 181), the example command invocations use the incorrect namespace
"/shared:development:pr-generator"; update those occurrences to
"ring-dev-team:pr-generator" so examples and sample invocations match the
correct command format, preserving any flags and arguments (e.g., --title,
--issue) exactly as they appear.
</details>
<!-- This is an auto-generated comment by CodeRabbit -->
| def main(): | ||
| try: | ||
| input_data = json.load(sys.stdin) | ||
| except json.JSONDecodeError as e: | ||
| print(f"Error: Invalid JSON input: {e}", file=sys.stderr) | ||
| sys.exit(1) | ||
|
|
||
| hook_event = input_data.get("hook_event_name", "") | ||
| tool_name = input_data.get("tool_name", "") | ||
| tool_input = input_data.get("tool_input", {}) | ||
| tool_response = input_data.get("tool_response", {}) | ||
|
|
||
| if hook_event != "PostToolUse": | ||
| sys.exit(0) | ||
|
|
||
| if tool_name in ["Write", "Edit", "MultiEdit"]: | ||
| file_path = tool_input.get("file_path", "") | ||
| if file_path: | ||
| filename = os.path.basename(file_path) | ||
|
|
||
| if tool_name == "Write": | ||
| title = "File Created ◉" | ||
| message = f"Created: {filename}" | ||
| else: | ||
| title = "File Modified ◉" | ||
| message = f"Modified: {filename}" | ||
|
|
||
| send_notification(title, message) | ||
|
|
||
| elif tool_name == "Bash": | ||
| command = tool_input.get("command", "") | ||
| success = tool_response.get("success", True) | ||
|
|
||
| important_commands = [ | ||
| "npm install", | ||
| "npm run", | ||
| "yarn", | ||
| "git", | ||
| "docker", | ||
| "pytest", | ||
| "jest", | ||
| ] | ||
| if any(cmd in command.lower() for cmd in important_commands): | ||
| if success: | ||
| title = "Command Completed ◉" | ||
| message = ( | ||
| f"Executed: {command[:50]}{'...' if len(command) > 50 else ''}" | ||
| ) | ||
| urgency = "normal" | ||
| else: | ||
| title = "Command Failed ◉" | ||
| message = f"Failed: {command[:50]}{'...' if len(command) > 50 else ''}" | ||
| urgency = "critical" | ||
|
|
||
| send_notification(title, message, urgency) | ||
|
|
||
| elif tool_name == "Task": | ||
| description = tool_input.get("description", "") | ||
| if description: | ||
| title = "Subagent Task Started ◉" | ||
| message = f"Task: {description}" | ||
| send_notification(title, message) | ||
|
|
||
| sys.exit(0) | ||
|
|
There was a problem hiding this comment.
Add required JSON output for hook compliance.
Hook scripts must output JSON with success/error fields per the coding guidelines. The script currently exits silently without any JSON output, which doesn't conform to the hook contract.
Apply this diff to add compliant JSON output:
def main():
try:
input_data = json.load(sys.stdin)
except json.JSONDecodeError as e:
- print(f"Error: Invalid JSON input: {e}", file=sys.stderr)
+ error_output = {
+ "success": False,
+ "error": f"Invalid JSON input: {e}"
+ }
+ print(json.dumps(error_output))
sys.exit(1)
hook_event = input_data.get("hook_event_name", "")
tool_name = input_data.get("tool_name", "")
tool_input = input_data.get("tool_input", {})
tool_response = input_data.get("tool_response", {})
if hook_event != "PostToolUse":
+ success_output = {
+ "success": True,
+ "message": "Not a PostToolUse event, skipping notification"
+ }
+ print(json.dumps(success_output))
sys.exit(0)
if tool_name in ["Write", "Edit", "MultiEdit"]:
file_path = tool_input.get("file_path", "")
if file_path:
filename = os.path.basename(file_path)
if tool_name == "Write":
title = "File Created ◉"
message = f"Created: {filename}"
else:
title = "File Modified ◉"
message = f"Modified: {filename}"
send_notification(title, message)
elif tool_name == "Bash":
command = tool_input.get("command", "")
success = tool_response.get("success", True)
important_commands = [
"npm install",
"npm run",
"yarn",
"git",
"docker",
"pytest",
"jest",
]
if any(cmd in command.lower() for cmd in important_commands):
if success:
title = "Command Completed ◉"
message = (
f"Executed: {command[:50]}{'...' if len(command) > 50 else ''}"
)
urgency = "normal"
else:
title = "Command Failed ◉"
message = f"Failed: {command[:50]}{'...' if len(command) > 50 else ''}"
urgency = "critical"
send_notification(title, message, urgency)
elif tool_name == "Task":
description = tool_input.get("description", "")
if description:
title = "Subagent Task Started ◉"
message = f"Task: {description}"
send_notification(title, message)
+ success_output = {
+ "success": True,
+ "message": "Notification hook completed"
+ }
+ print(json.dumps(success_output))
sys.exit(0)Based on learnings: "Hook scripts must output JSON with success/error fields; SessionStart hooks run on 'startup|resume' and 'clear|compact' events; use '${CLAUDE_PLUGIN_ROOT}' variable for plugin root resolution"
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
dev-team/commands/quality/technical-debt.md (1)
29-71: Remove duplicate Examples section.Lines 29–48 and lines 50–71 contain the exact same Examples section, creating redundancy and confusion. This was flagged in a previous review but was not corrected. Only one Examples section should remain.
Apply this diff to remove lines 50–71:
/ring-dev-team:quality:technical-debt --git-scope=branch --target=src/ # Analyze branch changes in src/ only-## Examples
-
-/ring-dev-team:quality:technical-debt --target=<project-path-or-component> --Examples:
-```bash
-# Git-focused debt analysis (recommended for feature development)
-/ring-dev-team:quality:technical-debt --git-scope=all-changes # Analyze debt in current changes
-/ring-dev-team:quality:technical-debt --git-scope=branch # Analyze debt introduced in feature branch
-/ring-dev-team:quality:technical-debt --git-scope=staged # Analyze debt in staged changes-# Traditional project-wide analysis
-/ring-dev-team:quality:technical-debt --target=. # Analyze entire project
-/ring-dev-team:quality:technical-debt --target=src/auth # Analyze auth module
-/ring-dev-team:quality:technical-debt --target=backend/api # Analyze API layer-# Combined approaches
-/ring-dev-team:quality:technical-debt --git-scope=branch --target=src/ # Analyze branch changes in src/ only
-```Process
</blockquote></details> </blockquote></details> <details> <summary>🧹 Nitpick comments (8)</summary><blockquote> <details> <summary>dev-team/commands/analysis/code-searcher.md (1)</summary><blockquote> `127-131`: **Add language specifier to code block.** Fenced code blocks without language tags may not render correctly in some markdown viewers. Lines 127–131 show a CoD example output without specifying a language. Apply this diff: ```diff -``` +``` Target→Glob[pattern]→n→Grep[name]→file:line→signature -``` +```Also applies to other bare ``` blocks in similar example sections (e.g., lines 186, 194).
dev-team/commands/quality/clean-comments.md (1)
52-54: Add language specifier to code block.Line 52–54 shows a usage example without a language specifier. Consider adding the language tag for consistency with adjacent blocks.
Apply this diff:
-``` +```bash /ring-dev-team:quality:clean-comments --target=<project-path-or-component> -``` +```bashdev-team/commands/utils/markdown-syntax.md (1)
11-11: Capitalize "Markdown" per style guides.The markup language "Markdown" should be capitalized throughout the document. LanguageTool flags instances at lines 11, 26, 53, 118, and 130 where it appears lowercase.
Examples of changes:
- Line 11:
Format text in markdown syntax→Format text in Markdown syntax- Line 26:
analyze its markdown syntax→analyze its Markdown syntax- Similar changes needed at lines 53, 118, 130
Also applies to: 26-26, 53-53, 118-118, 130-130
dev-team/commands/quality/clean-project.md (1)
29-141: Add language specifiers to bash code blocks.Fenced code blocks containing bash commands should include the language specifier. Lines 29–52 and 90–140 lack
bashlanguage tags.Apply diffs to both blocks:
-``` +```bash # 1. Validate git repository if ! git rev-parse --git-dir >/dev/null 2>&1; thenand
-``` +```bash # 1. Validate git repository if ! git rev-parse --git-dir >/dev/null 2>&1; thendev-team/commands/quality/technical-debt.md (1)
29-48: Add language specifiers to fenced code blocks.Fenced code blocks containing bash commands should include the
bashlanguage specifier for proper syntax highlighting. This applies to lines 29–48 and 52–71 (in the current duplicated sections; address after removing the duplicate).Apply diffs:
-``` +```bash /ring-dev-team:quality:technical-debt --git-scope=all-changes...Also applies to: 52-71
dev-team/commands/documentation/document.md (2)
49-49: Add periods after "etc." abbreviation per style guide.Lines 49 and 157 use "etc" without a period. In American English style, abbreviations like "etc." require a period.
Apply diffs:
- ...architecture, bugs, performance, security, etc + ...architecture, bugs, performance, security, etc.- Only create new docs if absolutely essential (README missing, etc) + Only create new docs if absolutely essential (README missing, etc.)Also applies to: 157-157
125-139: Add language specifier to documentation format example block.Lines 125–139 show a documentation overview format example without a language specifier. Consider adding a language tag (e.g.,
textormarkdown) for consistency.Apply this diff:
-``` +```text DOCUMENTATION OVERVIEW ├── README.md - [status: current/outdated]dev-team/commands/analysis/knowledger-extract.md (1)
305-305: Minor grammar: hyphenate compound modifier.Line 305 uses "knowledge sharing practices" but should use a hyphen when used as a compound modifier before the noun: "knowledge-sharing practices".
Apply this diff:
- Establish knowledge sharing practices + Establish knowledge-sharing practices
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (19)
dev-team/commands/analysis/code-searcher.md(1 hunks)dev-team/commands/analysis/diagram.md(1 hunks)dev-team/commands/analysis/knowledger-extract.md(1 hunks)dev-team/commands/debugging/fix-problem.md(1 hunks)dev-team/commands/documentation/architecture-document.md(1 hunks)dev-team/commands/documentation/document.md(1 hunks)dev-team/commands/planning/estimate.md(1 hunks)dev-team/commands/planning/options.md(1 hunks)dev-team/commands/planning/question.md(1 hunks)dev-team/commands/quality/clean-comments.md(1 hunks)dev-team/commands/quality/clean-project.md(1 hunks)dev-team/commands/quality/code-improve.md(1 hunks)dev-team/commands/quality/technical-debt.md(1 hunks)dev-team/commands/security/predict-issue.md(1 hunks)dev-team/commands/utils/markdown-syntax.md(1 hunks)dev-team/commands/workflow/find-todos.md(1 hunks)dev-team/commands/workflow/pr-generator.md(1 hunks)dev-team/commands/workflow/prompt-engineer.md(1 hunks)dev-team/commands/workflow/summary.md(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- dev-team/commands/workflow/pr-generator.md
🚧 Files skipped from review as they are similar to previous changes (6)
- dev-team/commands/workflow/prompt-engineer.md
- dev-team/commands/quality/code-improve.md
- dev-team/commands/analysis/diagram.md
- dev-team/commands/planning/question.md
- dev-team/commands/workflow/find-todos.md
- dev-team/commands/security/predict-issue.md
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{md,sh,json}
📄 CodeRabbit inference engine (CLAUDE.md)
Always use fully qualified agent/skill/command invocation names in the format 'ring-{plugin}:{component-name}' to prevent ambiguity in multi-plugin environments
Files:
dev-team/commands/analysis/code-searcher.mddev-team/commands/quality/technical-debt.mddev-team/commands/workflow/summary.mddev-team/commands/documentation/document.mddev-team/commands/planning/estimate.mddev-team/commands/utils/markdown-syntax.mddev-team/commands/documentation/architecture-document.mddev-team/commands/planning/options.mddev-team/commands/analysis/knowledger-extract.mddev-team/commands/quality/clean-project.mddev-team/commands/debugging/fix-problem.mddev-team/commands/quality/clean-comments.md
🧠 Learnings (8)
📓 Common learnings
Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: When modifying agents, skills, commands, or hooks, ensure consistency across CLAUDE.md, MANUAL.md, README.md, ARCHITECTURE.md, plugin hooks, and using-* skills; search repository for old names if renaming
Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to tw-team/agents/*.md : Technical writing agents must produce: Functional Writer for guides/tutorials/conceptual docs, API Writer for API reference documentation, Docs Reviewer for quality review with standardized voice and tone
📚 Learning: 2025-12-04T13:04:35.163Z
Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/agents/{backend-engineer*,devops-engineer,sre,qa-analyst,frontend-engineer,finops-automation}.md : For backend engineers: divide implementations into Summary, Implementation, Files Changed, Testing, and Next Steps sections. For designers and finops: use Analysis, Findings, Recommendations, and Next Steps sections.
Applied to files:
dev-team/commands/analysis/code-searcher.mddev-team/commands/quality/technical-debt.mddev-team/commands/workflow/summary.mddev-team/commands/planning/estimate.mddev-team/commands/documentation/architecture-document.mddev-team/commands/analysis/knowledger-extract.mddev-team/commands/debugging/fix-problem.md
📚 Learning: 2025-12-04T13:04:35.163Z
Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/agents/{code-reviewer,business-logic-reviewer,security-reviewer}.md : Code review agents must produce output with VERDICT (PASS|FAIL|NEEDS_DISCUSSION), Summary, Issues Found, Categorized Issues (Critical/High/Medium/Low), What Was Done Well, and Next Steps sections
Applied to files:
dev-team/commands/analysis/code-searcher.mddev-team/commands/workflow/summary.mddev-team/commands/utils/markdown-syntax.md
📚 Learning: 2025-12-04T13:04:35.163Z
Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/*.{md,sh,json} : Always use fully qualified agent/skill/command invocation names in the format 'ring-{plugin}:{component-name}' to prevent ambiguity in multi-plugin environments
Applied to files:
dev-team/commands/quality/technical-debt.mddev-team/commands/workflow/summary.mddev-team/commands/documentation/document.mddev-team/commands/planning/estimate.mddev-team/commands/debugging/fix-problem.md
📚 Learning: 2025-12-04T13:04:35.163Z
Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to {**/skills/*,**/agents/*.md,**/commands/*.md,**/hooks/*.sh} : Use kebab-case for skill directory names and filenames, {domain}-reviewer.md format for agents, /ring-{plugin}:{action} format for commands, {event}-{purpose}.sh format for hooks
Applied to files:
dev-team/commands/quality/technical-debt.mddev-team/commands/documentation/document.mddev-team/commands/planning/estimate.mddev-team/commands/debugging/fix-problem.md
📚 Learning: 2025-12-04T13:04:35.163Z
Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: When modifying agents, skills, commands, or hooks, ensure consistency across CLAUDE.md, MANUAL.md, README.md, ARCHITECTURE.md, plugin hooks, and using-* skills; search repository for old names if renaming
Applied to files:
dev-team/commands/quality/technical-debt.mddev-team/commands/documentation/document.mddev-team/commands/debugging/fix-problem.md
📚 Learning: 2025-12-04T13:04:35.163Z
Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-04T13:04:35.163Z
Learning: Applies to **/agents/*.md : Agent output must follow the appropriate schema (Implementation, Analysis, Reviewer, Exploration, or Planning) with all required_sections validated against their regex patterns
Applied to files:
dev-team/commands/workflow/summary.mddev-team/commands/debugging/fix-problem.md
📚 Learning: 2025-12-03T19:09:48.358Z
Learnt from: CR
Repo: LerianStudio/ring PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-03T19:09:48.358Z
Learning: Applies to CLAUDE.md : Extract guidelines from CLAUDE.md file
Applied to files:
dev-team/commands/planning/estimate.md
🪛 LanguageTool
dev-team/commands/quality/technical-debt.md
[grammar] ~495-~495: Use a hyphen to join words.
Context: ...Metrics:** - Reduction in critical/high priority debt items - Improvement in cod...
(QB_NEW_EN_HYPHEN)
dev-team/commands/documentation/document.md
[style] ~49-~49: In American English, abbreviations like “etc.” require a period.
Context: ...hitecture, bugs, performance, security, etc 4. Update EVERYTHING affected - Not...
(ETC_PERIOD)
[style] ~157-~157: ‘absolutely essential’ might be wordy. Consider a shorter alternative.
Context: ...nd formatting - Only create new docs if absolutely essential (README missing, etc) **Preserve secti...
(EN_WORDINESS_PREMIUM_ABSOLUTELY_ESSENTIAL)
[style] ~157-~157: In American English, abbreviations like “etc.” require a period.
Context: ...f absolutely essential (README missing, etc) Preserve sections: ```markdown <...
(ETC_PERIOD)
dev-team/commands/utils/markdown-syntax.md
[uncategorized] ~11-~11: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...syntax ## Instructions Format text in markdown syntax or identify and fix issues in ex...
(MARKDOWN_NNP)
[style] ~11-~11: Consider using a different verb for a more formal wording.
Context: ...text in markdown syntax or identify and fix issues in existing markdown files. Enfo...
(FIX_RESOLVE)
[uncategorized] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ile path, read the file and analyze its markdown syntax. - If input is text content,...
(MARKDOWN_NNP)
[uncategorized] ~53-~53: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ut modifying the file. - Verify all markdown syntax is valid and follows standard co...
(MARKDOWN_NNP)
[uncategorized] ~117-~117: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...pdate the specified file with compliant markdown syntax - Or, display the properly forma...
(MARKDOWN_NNP)
[uncategorized] ~118-~118: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ax - Or, display the properly formatted markdown text for manual use - Report the compre...
(MARKDOWN_NNP)
[uncategorized] ~130-~130: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ighting 5. Links and images use correct markdown syntax 6. Document structure is logical...
(MARKDOWN_NNP)
dev-team/commands/analysis/knowledger-extract.md
[grammar] ~305-~305: Use a hyphen to join words.
Context: ...elopment workflows - Establish knowledge sharing practices ### Maintenance Strat...
(QB_NEW_EN_HYPHEN)
dev-team/commands/quality/clean-project.md
[grammar] ~43-~43: Use a hyphen to join words.
Context: ...- Group similar files for batch decision making - Git-aware: Focus on arti...
(QB_NEW_EN_HYPHEN)
dev-team/commands/quality/clean-comments.md
[style] ~42-~42: The words ‘explain’ and ‘explanation’ are quite similar. Consider replacing ‘explain’ with a different word.
Context: ... Code Comment Rules 1. Always try to explain yourself in code - Remove comments th...
(VERB_NOUN_SENT_LEVEL_REP)
[style] ~47-~47: The words ‘explanation’ and ‘explaining’ are quite similar. Consider replacing ‘explaining’ with a different word.
Context: ...anation of intent** - Preserve comments explaining WHY, not WHAT 7. **Keep warnings of con...
(VERB_NOUN_SENT_LEVEL_REP)
[style] ~48-~48: Try using a synonym here to strengthen your wording.
Context: ...p warnings of consequences** - Preserve comments about important side effects 8. **Keep ...
(COMMENT_REMARK)
🪛 markdownlint-cli2 (0.18.1)
dev-team/commands/quality/technical-debt.md
125-125: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
dev-team/commands/documentation/document.md
125-125: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
dev-team/commands/quality/clean-project.md
29-29: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
52-52: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
🔇 Additional comments (5)
dev-team/commands/documentation/architecture-document.md (1)
1-242: Well-structured architecture documentation command.The comprehensive guidance and templates for architecture documentation align with best practices. No issues detected.
dev-team/commands/workflow/summary.md (1)
1-67: Well-structured summary command specification.The workflow summary command is properly documented with correct namespace references and clear usage patterns.
dev-team/commands/analysis/knowledger-extract.md (1)
1-19: Namespace and format corrections properly applied.The command namespace, usage examples, and overall structure correctly follow the
ring-dev-team:{category}:{command}format as required by coding guidelines. The comprehensive knowledge extraction workflow is well-organized across 8 phases with clear bash patterns and templates.dev-team/commands/planning/options.md (1)
1-100: Well-structured analysis template with correct namespace formatting.The planning options command follows all format guidelines with the correct
ring-dev-team:planning:optionsnamespace. The structured template provides clear sections for problem understanding, option evaluation, recommendation matrix, and next steps—giving users a robust framework for analyzing multiple approaches.dev-team/commands/planning/estimate.md (1)
1-145: Comprehensive data-driven estimation workflow with correct namespace.The estimation command properly uses the
ring-dev-team:planning:estimatenamespace format and provides a complete methodology for generating data-backed estimates. The workflow is well-structured across historical analysis, complexity metrics, estimation model building, and confidence assessment, with clear examples and best practices for team usage.
| **Arguments:** | ||
|
|
||
| - `--input`: Error message, issue file path, or problem description (required) | ||
| - `--git-scope`: Git scope for focusing problem analysis on specific changes - staged|unstaged|all-changes|branch|last-commit|commit-range=<range> (optional) |
There was a problem hiding this comment.
Undocumented --source argument in examples contradicts Arguments section.
The Arguments section (lines 30–33) documents only --input and --git-scope, but the Source Examples section explicitly uses --source=error, --source=issue, and --source=description (lines 118, 140, 197), and Execution Flow references "Parse --source flag" (line 252).
This creates ambiguity: should --source be documented as an optional argument, or is source auto-detected from --input content?
Clarify the intended behavior and update accordingly:
Option A: If --source is optional with auto-detection, remove it from examples (lines 118, 140, 197) and update Execution Flow line 252.
Option B: If --source is an optional flag for explicit source specification, add it to the Arguments section:
**Arguments:**
- `--input`: Error message, issue file path, or problem description (required)
+- `--source`: Explicitly specify source type (auto-detected if omitted) - error|issue|description (optional)
- `--git-scope`: Git scope for focusing problem analysis on specific changes - staged|unstaged|all-changes|branch|last-commit|commit-range=<range> (optional)Also applies to: 118-118, 140-140, 197-197, 252-252
🤖 Prompt for AI Agents
dev-team/commands/debugging/fix-problem.md lines 30-33: The docs list only
--input and --git-scope but examples and Execution Flow use --source; add a
documented optional --source flag to Arguments (accepted values:
error|issue|description) and describe its behavior (explicitly sets input type,
fallback to auto-detection when omitted), update the three examples at lines
118, 140, 197 to remain valid, and modify the Execution Flow at line 252 to
reflect "Parse --source flag (use explicit value if provided, otherwise attempt
auto-detection from --input)" so examples and flow are consistent with the
Arguments section.
Add comprehensive slash command library organized by category:
Add context7 MCP server for documentation lookups and desktop notification hooks for tool completion events.
Summary by CodeRabbit
Documentation
New Features
✏️ Tip: You can customize this high-level summary in your review settings.