Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make libcrypto and libssl paths overrideable #95

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

nydragon
Copy link
Contributor

@nydragon nydragon commented Jun 12, 2024

Allows overriding libcrypto and libssl paths by setting ACSM_LIBCRYPTO and ACSM_LIBSSL (both are necessary).

This is necessary to properly use the plugin on NixOS where library paths change quite frequently and are not necessarily in the scope of an application.

related to #68
closes #94

It is necessary to properly use this plugin on NixOS and also allows
overriding for testing & other purposes.
@ThePinkUnicorn6
Copy link

Thank you for this, works perfectly for me 👍

@Leseratte10
Copy link
Owner

Huh, sorry, I seem to have missed this merge request.

I've never used NixOS so I'm not sure how this works / why it's necessary, but given that the issue report has four upvotes, the code looks sensible and someone else confirmed it's working, I see no reason to not merge it.

Thanks.

@Leseratte10 Leseratte10 merged commit 25a395f into Leseratte10:master Aug 7, 2024
@nydragon
Copy link
Contributor Author

nydragon commented Aug 7, 2024

Huh, sorry, I seem to have missed this merge request.

I've never used NixOS so I'm not sure how this works / why it's necessary, but given that the issue report has four upvotes, the code looks sensible and someone else confirmed it's working, I see no reason to not merge it.

Thanks.

Thank you! I guess it would also find uses in trying out libraries that arent in the default path

@nydragon
Copy link
Contributor Author

nydragon commented Aug 7, 2024

@Leseratte10 Would you mind if I submit a PR explaining the install/use process for NixOS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libcrypto and libssl location overrideable by env variables
3 participants