Fix too long IDs #17
Merged
Fix too long IDs #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix this issue. It hashes IDs using SHA256, then cuts any part that wouldn't fit in
FixedString32Bytes.You can test this by installing this mod, and spawning an item like
Rainbow Stack of Small Jars of pickles. Before, the item would be displayed as???in the terminal. Now, the item correctly displays, using the quite long name.If any issue comes up from the lack of size, the type of
ItemData.IDcan be changed toFixedString64Bytes, but it comes with being less memory efficient.Obviously, this breaks any save that was made before this. It also ruins the logging using IDs, since they are less informative.