Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add initial support for ASI MPX3 detectors #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Add initial support for ASI MPX3 detectors #118

wants to merge 2 commits into from

Conversation

sk1p
Copy link
Member

@sk1p sk1p commented May 17, 2023 •
edited
Loading

TODO

  • Active mode: controller, HTTP API in the rust crate
  • Rename: mpx3 → ??? (it's also useful for the frame based mode of tpx3)
  • Simulator:
    • Need to test with real-looking data, I think
    • Write minimal simulator for both data and control sockets, for integration tests
  • Test coverage
  • Release and add dependency on libertem_asi_mpx3 Python package
  • Documentation
    • README
    • New document in the detectors section
    • Double-check docstrings

Contributor Checklist:

  • I have added or updated my entry in the creators.json file
  • I have added a changelog entry for my contribution
  • I have added/updated documentation for all user-facing changes
  • I have added/updated test cases

Reviewer Checklist:

  • /azp run libertem.libertem-live-data passed

@sk1p sk1p added the enhancement New feature or request label May 17, 2023
@sk1p
Copy link
Member Author

sk1p commented May 17, 2023

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sk1p
asi_tpx3: don't crash in cancelled scan
6360c03 
Happens often at the beginning of the acquisition, before
synchronization is complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sk1p