update_parameters_experimental w/ sync run_udf_iter
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 79.80% 71.28% -8.52%
==========================================
Files 35 35
Lines 3442 3462 +20
Branches 581 581
==========================================
- Hits 2747 2468 -279
- Misses 559 840 +281
- Partials 136 154 +18 ☔ View full report in Codecov by Sentry. |
sk1p
force-pushed
the
iter-sync-update-params
branch
from
0ccf600
to
c51ea2d
Compare
sk1p
force-pushed
the
iter-sync-update-params
branch
from
35ca25b
to
b5e3699
Compare
|
Bump to 0.3 since important for overfocus project. |
sk1p
force-pushed
the
iter-sync-update-params
branch
from
b5e3699
to
1f2b93e
Compare
Instead of a context manager, use explicit methods `start_acquisition` and `end_acquisition`, otherwise we would have to manually call the context manager methods (`__enter__`/`__exit__`)
|
/azp run libertem.libertem-live-data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sk1p
changed the title
update_parameters_experimental w/ sync run_udf_iterupdate_parameters_experimental w/ sync run_udf_iter
uellue
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly right now useful for the test case - I'm not really happy about the implementation.Contributor Checklist:
Reviewer Checklist:
/azp run libertem.libertem-live-datapassed