Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Basic X-Spectrum support #56

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

uellue
Copy link
Member

@uellue uellue commented Aug 19, 2022

Based on #51

Runs with the simulator with default settings.

DectrisLivePartition refactored to FullframeLivePartition for
all detectors that can read a sequence of full frames from the queue.

FIXME probably Merlin can be ported to that as well?

FIXME proper support of basic settings analogous to Dectris
FIXME support for multiple detectors and/or receivers
FIXME support for post decoders?

Contributor Checklist:

  • I have added or updated my entry in the creators.json file
  • I have added a changelog entry for my contribution
  • I have added/updated documentation for all user-facing changes
  • I have added/updated test cases

Reviewer Checklist:

  • /azp run libertem.libertem-live-data passed

@uellue uellue added this to the 0.2 milestone Aug 19, 2022
@uellue
Copy link
Member Author

uellue commented Aug 19, 2022

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #56 (d205c2b) into master (abd612f) will decrease coverage by 5.16%.
The diff coverage is 41.91%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   73.40%   68.23%   -5.17%     
==========================================
  Files          23       26       +3     
  Lines        2474     2714     +240     
  Branches      388      417      +29     
==========================================
+ Hits         1816     1852      +36     
- Misses        553      755     +202     
- Partials      105      107       +2     
Impacted Files Coverage Δ
...c/libertem_live/detectors/xspectrum/acquisition.py 28.40% <28.40%> (ø)
src/libertem_live/detectors/xspectrum/mock.py 29.68% <29.68%> (ø)
src/libertem_live/detectors/base/acquisition.py 87.01% <84.12%> (-12.99%) ⬇️
src/libertem_live/detectors/dectris/acquisition.py 78.83% <100.00%> (-2.10%) ⬇️
src/libertem_live/detectors/xspectrum/__init__.py 100.00% <100.00%> (ø)
src/libertem_live/detectors/dectris/mock.py 32.07% <0.00%> (-64.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sk1p
Copy link
Member

sk1p commented Aug 22, 2022

CI failures should mostly be fixed by rebasing on top of current #51 (or master once that is merged)

@sk1p
Copy link
Member

sk1p commented Aug 22, 2022

simulator

Thoughts on testing this in CI? Can we re-distribute the docker image we built, for example in https://github.com/LiberTEM/base-images

I'm not 100% sure how to integrate that into our current azure infrastructure - as Docker-in-Docker is not an option for our on-premise runner.... :/

uellue and others added 4 commits August 24, 2022 14:19
Runs with the simulator with default settings.

DectrisLivePartition refactored to FullframeLivePartition for
all detectors that can read a sequence of full frames from the queue.

FIXME probably Merlin can be ported to that as well?

FIXME proper support of basic settings analogous to Dectris
FIXME support for multiple detectors and/or receivers
FIXME support for post decoders?
@uellue
Copy link
Member Author

uellue commented Aug 24, 2022

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@uellue
Copy link
Member Author

uellue commented Aug 24, 2022

/azp run libertem.libertem-live-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@uellue uellue modified the milestones: 0.2, 0.3 Apr 18, 2023
@uellue
Copy link
Member Author

uellue commented Apr 18, 2023

Postponed to 0.3

@sk1p sk1p modified the milestones: 0.3, 0.4 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants