15 update tests for fkl 020 and c20 #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 30, 2025 19:51
remove cuda 11
updated test for new fkl syntax
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to use FKL (Fused Kernel Library) version 0.2.0 and migrates from C++17 to C++20 standard. The changes remove support for CUDA 11.x and update API calls to match the new FKL version.
- Updates FKL dependency from version 0.1.6 to 0.2.0
- Migrates C++ standard from 17 to 20 across all build configurations
- Updates include paths and API calls to match FKL 0.2.0 breaking changes
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| include/fast_npp.cuh | Updates FKL include paths and API calls to match 0.2.0 interface changes |
| include/CMakeLists.txt | Sets C++ standard to 20 for header library |
| fkl | Updates submodule commit to FKL 0.2.0 |
| cmake/libs/fkl.cmake | Updates FKL version numbers to 0.2.0 |
| cmake/discover_tests.cmake | Sets C++ standard to 20 for test targets |
| benchmarks/CMakeLists.txt | Sets C++ standard to 20 for benchmark targets |
| .github/workflows/cmake-windows-amd64.yml | Removes CUDA 11.8 toolset, keeping only CUDA 12.9 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| int currentDevice{ 0 }; | ||
| gpuErrchk(cudaGetDevice(¤tDevice)); | ||
| std::array<fk::Ptr2D<uchar3>, BATCH> srcBatch; | ||
| std::array<fk::Ptr2D<uchar3>, BATCH> srcBatch; |
There was a problem hiding this comment.
Trailing whitespace should be removed from this line.
Suggested change
| std::array<fk::Ptr2D<uchar3>, BATCH> srcBatch; | |
| std::array<fk::Ptr2D<uchar3>, BATCH> srcBatch; |
Comment on lines
+42
to
+43
| h_pBatchSrc[i].nStep, fk::MemType::Device, | ||
| currentDevice); |
There was a problem hiding this comment.
[nitpick] The line break after the comma creates inconsistent formatting. Consider keeping the parameter list on fewer lines or align the continuation properly.
added 2 commits
October 30, 2025 20:07
remove ifdefs for cuda11
albertandaluz
force-pushed
the
15-update-tests-for-fkl-020-and-c20
branch
from
a162347 to
6e6b115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed cuda 11.x support
use c++20 in tests
require fkl 0.2.0 as minimum