Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 06-manipulating-MARC-data-basics.md #147

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

jenmawe
Copy link
Collaborator

@jenmawe jenmawe commented Jul 23, 2024

Ensured 2 spaces after marc field 856, cleaned up language and added language on find or find all search results window not closing automatically

closes #141

Ensured 2 spaces after marc field 856, cleaned up language and added language on find or find all search results window not closing automatically
Copy link

github-actions bot commented Jul 23, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-marcedit/compare/md-outputs..md-outputs-PR-147

The following changes were observed in the rendered markdown documents:

 06-manipulating-MARC-data-basics.md | 37 ++++++++++++++++++++++---------------
 md5sum.txt                          |  2 +-
 2 files changed, 23 insertions(+), 16 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-08-09 15:30:21 +0000

github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Copy link
Collaborator

@abigailsparling abigailsparling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggested changes for clarity

episodes/06-manipulating-MARC-data-basics.md Outdated Show resolved Hide resolved
episodes/06-manipulating-MARC-data-basics.md Outdated Show resolved Hide resolved
episodes/06-manipulating-MARC-data-basics.md Outdated Show resolved Hide resolved
episodes/06-manipulating-MARC-data-basics.md Outdated Show resolved Hide resolved
episodes/06-manipulating-MARC-data-basics.md Outdated Show resolved Hide resolved
jenmawe and others added 5 commits August 9, 2024 11:28
Co-authored-by: Abigail Sparling <33765342+abigailsparling@users.noreply.github.com>
Co-authored-by: Abigail Sparling <33765342+abigailsparling@users.noreply.github.com>
Co-authored-by: Abigail Sparling <33765342+abigailsparling@users.noreply.github.com>
Co-authored-by: Abigail Sparling <33765342+abigailsparling@users.noreply.github.com>
Co-authored-by: Abigail Sparling <33765342+abigailsparling@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Aug 9, 2024
@abigailsparling abigailsparling merged commit a6a019a into LibraryCarpentry:main Aug 9, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 9, 2024
Auto-generated via {sandpaper}
Source  : a6a019a
Branch  : main
Author  : Abigail Sparling <33765342+abigailsparling@users.noreply.github.com>
Time    : 2024-08-09 16:22:49 +0000
Message : Merge pull request #147 from jenmawe/episode06_spaces

Update 06-manipulating-MARC-data-basics.md
github-actions bot pushed a commit that referenced this pull request Aug 9, 2024
Auto-generated via {sandpaper}
Source  : e430909
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-08-09 16:23:35 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a6a019a
Branch  : main
Author  : Abigail Sparling <33765342+abigailsparling@users.noreply.github.com>
Time    : 2024-08-09 16:22:49 +0000
Message : Merge pull request #147 from jenmawe/episode06_spaces

Update 06-manipulating-MARC-data-basics.md
github-actions bot pushed a commit that referenced this pull request Aug 13, 2024
Auto-generated via {sandpaper}
Source  : e430909
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-08-09 16:23:35 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a6a019a
Branch  : main
Author  : Abigail Sparling <33765342+abigailsparling@users.noreply.github.com>
Time    : 2024-08-09 16:22:49 +0000
Message : Merge pull request #147 from jenmawe/episode06_spaces

Update 06-manipulating-MARC-data-basics.md
github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
Auto-generated via {sandpaper}
Source  : e430909
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-08-09 16:23:35 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a6a019a
Branch  : main
Author  : Abigail Sparling <33765342+abigailsparling@users.noreply.github.com>
Time    : 2024-08-09 16:22:49 +0000
Message : Merge pull request #147 from jenmawe/episode06_spaces

Update 06-manipulating-MARC-data-basics.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Episode 6 - only 1 space with 856
2 participants