Skip to content

CONCD-1183 Upgrade django-registration to version 5 #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025

Conversation

rasarkar
Copy link
Collaborator

Most important thing to note here is that django-registration 5 changes how the activation_key gets passed to the django_registration_activate view.

https://staff.loc.gov/tasks/browse/CONCD-1183

Copy link

github-actions bot commented Jun 18, 2025

🛡 Test Coverage Report 🛡

📜 Click to view full text coverage report
Name                                                                 Stmts   Miss Branch BrPart  Cover
------------------------------------------------------------------------------------------------------
concordia/__init__.py                                                    3      0      0      0   100%
concordia/admin/__init__.py                                            417      7     46      2    97%
concordia/admin/actions.py                                             106     18     28      4    78%
concordia/admin/filters.py                                             191      0     30      0   100%
concordia/admin/forms.py                                                68      0      2      0   100%
concordia/admin/views.py                                               350      0     96      0   100%
concordia/admin_site.py                                                 10      0      0      0   100%
concordia/api_views.py                                                  72      0     32      0   100%
concordia/apps.py                                                       13      0      0      0   100%
concordia/authentication_backends.py                                    14      0      8      0   100%
concordia/celery.py                                                     13      0      2      0   100%
concordia/consumers.py                                                  14      0      0      0   100%
concordia/context_processors.py                                         18      0      4      0   100%
concordia/contextmanagers.py                                            14      0      2      0   100%
concordia/converters.py                                                  5      0      0      0   100%
concordia/decorators.py                                                 27      0      6      0   100%
concordia/exceptions.py                                                  6      0      0      0   100%
concordia/forms.py                                                      59      0      6      0   100%
concordia/logging.py                                                    68      0     28      0   100%
concordia/maintenance.py                                                16      0      8      0   100%
concordia/management/__init__.py                                         0      0      0      0   100%
concordia/management/commands/__init__.py                                0      0      0      0   100%
concordia/management/commands/ensure_initial_site_configuration.py      29      0     10      0   100%
concordia/management/commands/import_site_reports.py                    25      0      8      0   100%
concordia/management/commands/print_frontend_test_urls.py               19      0      4      0   100%
concordia/middleware.py                                                  8      0      2      0   100%
concordia/models.py                                                    785      4     90      5    99%
concordia/passwords/__init__.py                                          0      0      0      0   100%
concordia/passwords/validators.py                                       42      0     26      0   100%
concordia/signals/__init__.py                                            0      0      0      0   100%
concordia/signals/handlers.py                                          132      0     28      0   100%
concordia/signals/signals.py                                             3      0      0      0   100%
concordia/storage.py                                                     6      0      0      0   100%
concordia/tasks.py                                                     762    151    136      8    79%
concordia/templatetags/__init__.py                                       0      0      0      0   100%
concordia/templatetags/concordia_filtering_tags.py                      16      0      4      0   100%
concordia/templatetags/concordia_media_tags.py                           5      0      0      0   100%
concordia/templatetags/concordia_querystring.py                         49      0     22      0   100%
concordia/templatetags/concordia_sharing_tags.py                         5      0      0      0   100%
concordia/templatetags/concordia_text_tags.py                           10      1      0      0    90%
concordia/templatetags/custom_math.py                                    5      0      0      0   100%
concordia/templatetags/reject_filter.py                                 12      2      4      2    75%
concordia/templatetags/truncation.py                                    37      0     14      0   100%
concordia/templatetags/visualization.py                                 15      0      2      0   100%
concordia/turnstile/__init__.py                                          0      0      0      0   100%
concordia/turnstile/context_processors.py                                3      0      0      0   100%
concordia/turnstile/fields.py                                           48      0     10      0   100%
concordia/turnstile/widgets.py                                          20      0      2      0   100%
concordia/utils/__init__.py                                             28      0      8      0   100%
concordia/utils/celery.py                                                6      2      0      0    67%
concordia/utils/logging.py                                              10      0      6      0   100%
concordia/utils/next_asset/__init__.py                                  12      0      0      0   100%
concordia/utils/next_asset/reviewable/__init__.py                        3      0      0      0   100%
concordia/utils/next_asset/reviewable/campaign.py                       56      0     10      0   100%
concordia/utils/next_asset/reviewable/topic.py                          56      0     10      0   100%
concordia/utils/next_asset/transcribable/__init__.py                     3      0      0      0   100%
concordia/utils/next_asset/transcribable/campaign.py                    53      0      8      0   100%
concordia/utils/next_asset/transcribable/topic.py                       53      0      8      0   100%
concordia/validators.py                                                 12      0      0      0   100%
concordia/version.py                                                     5      0      0      0   100%
concordia/views/__init__.py                                             74      0      6      0   100%
concordia/views/accounts.py                                            279      0     32      0   100%
concordia/views/ajax.py                                                311      0     70      0   100%
concordia/views/assets.py                                              247      0     64      0   100%
concordia/views/campaigns.py                                           153      0     32      0   100%
concordia/views/decorators.py                                           37      0      6      0   100%
concordia/views/items.py                                                66      0     10      0   100%
concordia/views/maintenance_mode.py                                     20      0      8      0   100%
concordia/views/projects.py                                             62      0     10      0   100%
concordia/views/rate_limit.py                                           13      0      4      0   100%
concordia/views/simple_pages.py                                         63      0     14      0   100%
concordia/views/topics.py                                               34      0      4      0   100%
concordia/views/utils.py                                               115      2     46      2    98%
concordia/views/visualizations.py                                       13      0      2      0   100%
concordia/widgets.py                                                     3      0      0      0   100%
configuration/__init__.py                                                0      0      0      0   100%
configuration/admin.py                                                   5      0      0      0   100%
configuration/apps.py                                                    4      0      0      0   100%
configuration/models.py                                                 37      0     10      0   100%
configuration/templatetags/__init__.py                                   0      0      0      0   100%
configuration/templatetags/configuration_tags.py                        10      0      0      0   100%
configuration/utils.py                                                  12      0      2      0   100%
exporter/__init__.py                                                     0      0      0      0   100%
exporter/admin.py                                                        0      0      0      0   100%
exporter/apps.py                                                         3      0      0      0   100%
exporter/exceptions.py                                                   6      0      0      0   100%
exporter/models.py                                                       0      0      0      0   100%
exporter/tabular_export/admin.py                                        24      0      2      0   100%
exporter/tabular_export/core.py                                        100      0     24      0   100%
exporter/utils.py                                                       17      0      8      0   100%
exporter/views.py                                                      160      0     20      0   100%
importer/__init__.py                                                     0      0      0      0   100%
importer/admin.py                                                      126      0     18      0   100%
importer/apps.py                                                         3      0      0      0   100%
importer/celery.py                                                       5      0      0      0   100%
importer/exceptions.py                                                   2      0      0      0   100%
importer/models.py                                                     119      0     14      0   100%
importer/tasks/__init__.py                                              13      0      2      0   100%
importer/tasks/assets.py                                                64      0     10      0   100%
importer/tasks/collections.py                                           57      1     18      1    97%
importer/tasks/decorators.py                                            38      3      6      1    91%
importer/tasks/images.py                                               115      0     22      0   100%
importer/tasks/items.py                                                154      0     42      0   100%
importer/utils/__init__.py                                               3      0      0      0   100%
importer/utils/excel.py                                                 17      0      8      0   100%
importer/utils/verify_images.py                                         14      0      2      0   100%
------------------------------------------------------------------------------------------------------
TOTAL                                                                 6415    191   1226     25    97%

@rasarkar rasarkar marked this pull request as ready for review June 19, 2025 11:59
@rasarkar rasarkar requested a review from joshuastegmaier June 19, 2025 11:59
I hadn't meant to change this line.
@jkueloc jkueloc merged commit ed5af50 into main Jun 20, 2025
7 checks passed
@rasarkar rasarkar deleted the CONCD-1183-rsar-django-registration-5.2.1 branch June 23, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants