fix(extensions): create AMD GPU overlay files for 5 services#386
Merged
Lightheartdevs merged 1 commit intoLight-Heart-Labs:resources/devfrom Mar 18, 2026
Conversation
Add compose.amd.yaml with ROCm device passthrough (/dev/dri, /dev/kfd) for services that support AMD GPUs per their manifests. Services: ollama, text-generation-webui, xtts, invokeai, rvc text-generation-webui overlay includes image swap to ROCm variant (default-rocm-v4.0) since the base image is NVIDIA-specific. Image pinned with sha256 digest per project convention. Excluded fooocus (CUDA-only image, no ROCm variant exists) and immich (GPU accel requires immich-machine-learning sidecar not yet in compose).
This was referenced Mar 18, 2026
Lightheartdevs
approved these changes
Mar 18, 2026
Collaborator
Lightheartdevs
left a comment
There was a problem hiding this comment.
Approve — Correct AMD GPU overlay files.
What's good
- Creates
compose.amd.yamlfor 5 services: invokeai, ollama, rvc, text-generation-webui, xtts - AMD pattern is correct:
/dev/dri+/dev/kfddevice passthrough,VIDEO_GID/RENDER_GIDgroup adds,HSA_OVERRIDE_GFX_VERSIONenv var - text-generation-webui AMD overlay correctly swaps to the ROCm image variant (
atinoda/text-generation-webui:default-rocm-v4.0) - Follows established pattern from core stack's
docker-compose.amd.yml
Merge after #385 (which extracts NVIDIA overlays from the same base compose files).
Lightheartdevs
approved these changes
Mar 18, 2026
Collaborator
Lightheartdevs
left a comment
There was a problem hiding this comment.
Approve — Correct AMD GPU overlay files.
Creates compose.amd.yaml for 5 services (invokeai, ollama, rvc, text-generation-webui, xtts) with the correct AMD pattern:
/dev/dri+/dev/kfddevice passthroughVIDEO_GID/RENDER_GIDgroup adds with sensible defaultsHSA_OVERRIDE_GFX_VERSIONenv var for GPU compatibility- text-generation-webui correctly swaps to the ROCm image variant
Follows established pattern from core stack's docker-compose.amd.yml. LGTM. Merge after #385.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Create
compose.amd.yamloverlay files for 5 services that support AMD GPUs per their manifests, providing ROCm device passthrough.Why
These services declare
gpu_backends: [amd, nvidia]in their manifests but had no AMD overlay — meaning AMD GPU users could not utilize GPU acceleration.How
Created
compose.amd.yamlfor each service with:/dev/driand/dev/kfddevice passthrough (ROCm)group_addfor video/render groupsHSA_OVERRIDE_GFX_VERSIONenvironment variableServices
default-rocm-v4.0(SHA pinned)Excluded services (with rationale)
runpod/fooocus:2.5.3is CUDA-only, no ROCm variant existsimmich-machine-learningsidecar which is not yet in the extensions library composeKnown limitations
Merge Order
This PR MUST merge after #385 (NVIDIA extraction). Three base compose files (ollama, text-gen-webui, rvc) currently contain
driver: nvidiadevice reservations. #385 removes those. If this PR merges first, Docker Compose would merge both NVIDIA and AMD device entries, causing runtime errors on AMD systems.Testing
docker compose configvalidation passed for all 5 services (base + AMD overlay)default-rocm-v4.0tag (verified exists on Docker Hub) with SHA pinPlatform Impact