Skip to content

fix(extensions): correct Milvus health port and add Ollama Apple Silicon support#389

Merged
Lightheartdevs merged 1 commit intoLight-Heart-Labs:mainfrom
yasinBursali:fix/c1c2-milvus-health-ollama-apple
Mar 18, 2026
Merged

fix(extensions): correct Milvus health port and add Ollama Apple Silicon support#389
Lightheartdevs merged 1 commit intoLight-Heart-Labs:mainfrom
yasinBursali:fix/c1c2-milvus-health-ollama-apple

Conversation

@yasinBursali
Copy link
Contributor

@yasinBursali yasinBursali commented Mar 18, 2026

What

  • Milvus manifest port corrected from 19530 (gRPC) to 9091 (HTTP metrics)
  • Ollama manifest gpu_backends updated to include apple at service and feature level

Why

Dashboard-api constructs health check URLs as http://{host}:{port}{health} (helpers.py:166).
Milvus serves /healthz on port 9091 (HTTP metrics endpoint), not 19530 (gRPC). The compose
healthcheck already uses http://localhost:9091/healthz — the manifest port must match or
dashboard health checks silently fail against the gRPC port.

Ollama has native Apple Silicon Metal support but its manifest only declared [amd, nvidia].
The continue service already declares [amd, nvidia, apple] as precedent.

How

  • Changed service.port from 19530 to 9091 in milvus manifest
  • external_port_default: 19530 preserved for user-facing gRPC access
  • Added apple to gpu_backends in ollama manifest (service + feature sections)

Testing

  • YAML syntax validated
  • Manifest field values verified programmatically
  • Critique Guardian review: approved

Known Considerations

  • port is returned in ServiceStatus to the dashboard UI — Milvus will display :9091
    instead of :19530. Non-issue for dev library; a health_port schema field is recommended
    before production promotion.
  • Ollama compose still declares NVIDIA GPU reservation in deploy.resources — harmless on
    macOS (Docker silently ignores), but should get an Apple overlay before production promotion.

Platform Impact

  • macOS: Ollama now correctly declares Apple Silicon support
  • Linux (NVIDIA/AMD): No change
  • Windows: No change

Merge Order

Can merge independently — touches different lines than other open PRs on this directory.

🤖 Generated with Claude Code

…con support

Milvus manifest port changed from 19530 (gRPC) to 9091 (HTTP metrics)
so dashboard-api health checks hit the correct endpoint. The compose
healthcheck already uses http://localhost:9091/healthz — the manifest
port must match. external_port_default remains 19530 for user-facing
gRPC access.

Ollama manifest gpu_backends updated to include apple at both service
and feature level. Ollama has native Apple Silicon Metal support and
the continue service already declares [amd, nvidia, apple].

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Copy link
Collaborator

@Lightheartdevs Lightheartdevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — Two small, correct fixes.

  1. Milvus port: 195309091 — health endpoint (/healthz) runs on port 9091, not the gRPC data port. Correct fix.
  2. Ollama gpu_backends: [amd, nvidia][amd, nvidia, apple] — Ollama supports Apple Silicon via Metal. Correct.

Tiny diff (+3/-3), no conflicts. Merge anytime.

Copy link
Collaborator

@Lightheartdevs Lightheartdevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — Two small, correct fixes.

  1. Milvus port: 195309091: Health endpoint (/healthz) runs on port 9091, not the gRPC data port. Correct.
  2. Ollama gpu_backends: [amd, nvidia][amd, nvidia, apple]: Ollama supports Apple Silicon via Metal. Correct.

+3/-3, no conflicts. LGTM.

@Lightheartdevs Lightheartdevs merged commit 1196245 into Light-Heart-Labs:main Mar 18, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants