fix(extensions): correct Milvus health port and add Ollama Apple Silicon support#389
Merged
Lightheartdevs merged 1 commit intoLight-Heart-Labs:mainfrom Mar 18, 2026
Conversation
…con support Milvus manifest port changed from 19530 (gRPC) to 9091 (HTTP metrics) so dashboard-api health checks hit the correct endpoint. The compose healthcheck already uses http://localhost:9091/healthz — the manifest port must match. external_port_default remains 19530 for user-facing gRPC access. Ollama manifest gpu_backends updated to include apple at both service and feature level. Ollama has native Apple Silicon Metal support and the continue service already declares [amd, nvidia, apple]. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Lightheartdevs
approved these changes
Mar 18, 2026
Collaborator
Lightheartdevs
left a comment
There was a problem hiding this comment.
Approve — Two small, correct fixes.
- Milvus
port: 19530→9091— health endpoint (/healthz) runs on port 9091, not the gRPC data port. Correct fix. - Ollama
gpu_backends: [amd, nvidia]→[amd, nvidia, apple]— Ollama supports Apple Silicon via Metal. Correct.
Tiny diff (+3/-3), no conflicts. Merge anytime.
Lightheartdevs
approved these changes
Mar 18, 2026
Collaborator
Lightheartdevs
left a comment
There was a problem hiding this comment.
Approve — Two small, correct fixes.
- Milvus
port: 19530→9091: Health endpoint (/healthz) runs on port 9091, not the gRPC data port. Correct. - Ollama
gpu_backends: [amd, nvidia]→[amd, nvidia, apple]: Ollama supports Apple Silicon via Metal. Correct.
+3/-3, no conflicts. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
portcorrected from 19530 (gRPC) to 9091 (HTTP metrics)gpu_backendsupdated to includeappleat service and feature levelWhy
Dashboard-api constructs health check URLs as
http://{host}:{port}{health}(helpers.py:166).Milvus serves
/healthzon port 9091 (HTTP metrics endpoint), not 19530 (gRPC). The composehealthcheck already uses
http://localhost:9091/healthz— the manifest port must match ordashboard health checks silently fail against the gRPC port.
Ollama has native Apple Silicon Metal support but its manifest only declared
[amd, nvidia].The
continueservice already declares[amd, nvidia, apple]as precedent.How
service.portfrom19530to9091in milvus manifestexternal_port_default: 19530preserved for user-facing gRPC accessappletogpu_backendsin ollama manifest (service + feature sections)Testing
Known Considerations
portis returned inServiceStatusto the dashboard UI — Milvus will display:9091instead of
:19530. Non-issue for dev library; ahealth_portschema field is recommendedbefore production promotion.
deploy.resources— harmless onmacOS (Docker silently ignores), but should get an Apple overlay before production promotion.
Platform Impact
Merge Order
Can merge independently — touches different lines than other open PRs on this directory.
🤖 Generated with Claude Code