Skip to content

[nvfuser] don't allow shape only nvfuser region #2041

[nvfuser] don't allow shape only nvfuser region

[nvfuser] don't allow shape only nvfuser region #2041

Triggered via pull request December 18, 2024 12:21
Status Success
Total duration 21s
Artifacts

auto-cc.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
auto-cc
Resource not accessible by integration { name: 'HttpError', id: '12392837864', status: 403, response: { url: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/pulls/1559', status: 403, headers: { 'access-control-allow-origin': '*', 'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset', connection: 'close', 'content-encoding': 'gzip', 'content-security-policy': "default-src 'none'", 'content-type': 'application/json; charset=utf-8', date: 'Wed, 18 Dec 2024 12:21:56 GMT', 'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', server: 'github.com', 'strict-transport-security': 'max-age=31536000; includeSubdomains; preload', 'transfer-encoding': 'chunked', vary: 'Accept-Encoding, Accept, X-Requested-With', 'x-accepted-github-permissions': 'pull_requests=write', 'x-content-type-options': 'nosniff', 'x-frame-options': 'deny', 'x-github-api-version-selected': '2022-11-28', 'x-github-media-type': 'github.v3; format=json', 'x-github-request-id': '6432:148A45:4CC24A0:97E0DC4:6762BE64', 'x-ratelimit-limit': '15000', 'x-ratelimit-remaining': '14979', 'x-ratelimit-reset': '1734527857', 'x-ratelimit-resource': 'core', 'x-ratelimit-used': '21', 'x-xss-protection': '0' }, data: { message: 'Resource not accessible by integration', documentation_url: 'https://docs.github.com/rest/pulls/pulls#update-a-pull-request', status: '403' } }, request: { method: 'PATCH', url: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/pulls/1559', headers: { accept: 'application/vnd.github.v3+json', 'user-agent': 'probot/12.2.5 octokit-core.js/3.6.0 Node.js/20.18.0 (linux; x64)', authorization: 'token [REDACTED]', 'content-type': 'application/json; charset=utf-8' }, body: '{"body":"Related: https://github.com/Lightning-AI/lightning-thunder/issues/1251\\r\\n\\r\\nMicrobenchmark\\r\\n```python\\r\\nimport torch\\r\\nimport torch.utils.benchmark\\r\\nimport thunder\\r\\n\\r\\n# Seen in HF-Qwen2 Model\\r\\n# [t6866] = nvFusion4(t6857)\\r\\n# # lora_res_12 = prims.reshape(t6857, (1, 4096, 16)) # lora_res_12: \\"cuda:0 bf16[1, 4096, 16]\\"\\r\\n# # t6866 = prims.reshape(lora_res_12, (4096, 16)) # t6866: \\"cuda:0 bf16[4096, 16]\\"\\r\\n\\r\\ndef fn(x):\\r\\n x = x.reshape(-1, 4096, 16)\\r\\n x = x.reshape(4096, 16)\\r\\n return x\\r\\n\\r\\n\\r\\nx = torch.randn(4096, 16, device=\\"cuda\\")\\r\\njfn = thunder.jit(fn, nv_enable_shape_only_fusion=False)\\r\\n\\r\\njfn(x)\\r\\n\\r\\ntimer = torch.utils.benchmark.Timer(\\"jfn(x)\\", globals={\\"jfn\\": jfn, \\"x\\": x})\\r\\n\\r\\nprint(timer.blocked_autorange(min_run_time=1))\\r\\n# print(thunder.last_traces(jfn)[-1])\\r\\n```\\r\\n\\r\\nBefore PR\\r\\n```python\\r\\n<torch.utils.benchmark.utils.common.Measurement object at 0x7305591c54e0>\\r\\njfn(x)\\r\\n Median: 36.18 us\\r\\n 3 measurements, 10000 runs per measurement, 1 thread\\r\\n```\\r\\n\\r\\nAfter PR\\r\\n```python\\r\\n<torch.utils.benchmark.utils.common.Measurement object at 0x7e533962cc10>\\r\\njfn(x)\\r\\n Median: 18.95 us\\r\\n IQR: 0.02 us (18.93 to 18.96)\\r\\n 6 measurements, 10000 runs per measurement, 1 thread\\r\\n```\\r\\n\\r\\nTODO \\r\\n* [x] Add tests!\\r\\n* [x] Check if CI works fine\\r\\n\\n\\ncc @tfogal"}', request: {} }, event: { id: '12392837864', name: 'pull_request', payload: { action: 'labeled', enterprise: { avatar_url: 'https://avatars.githubusercontent.com/b/230529?v=4', created_at: '2024-09-24T13:06:23Z', description: null, html_url: 'https://github.com/enterprises/Lightning-AI', id: 23052
auto-cc
HttpError: Resource not accessible by integration at /home/runner/work/_actions/Lightning-AI/probot/v5/node_modules/@octokit/core/node_modules/@octokit/request/dist-node/index.js:86:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Job.doExecute (/home/runner/work/_actions/Lightning-AI/probot/v5/node_modules/bottleneck/light.js:405:18) { name: 'AggregateError', event: { id: '12392837864', name: 'pull_request', payload: { action: 'labeled', enterprise: { avatar_url: 'https://avatars.githubusercontent.com/b/230529?v=4', created_at: '2024-09-24T13:06:23Z', description: null, html_url: 'https://github.com/enterprises/Lightning-AI', id: 230529, name: 'Lightning-AI', node_id: 'E_kgDOAAOEgQ', slug: 'Lightning-AI', updated_at: '2024-10-16T18:39:41Z', website_url: null }, label: { color: '8754A9', default: false, description: '', id: 6781724430, name: 'nvfuser', node_id: 'LA_kwDOLiCyD88AAAABlDjnDg', url: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/labels/nvfuser' }, number: 1559, organization: { avatar_url: 'https://avatars.githubusercontent.com/u/58386951?v=4', description: 'Turn ideas into AI, Lightning fast. Creators of PyTorch Lightning, Lightning AI Studio, TorchMetrics, Fabric, Lit-GPT, Lit-LLaMA', events_url: 'https://api.github.com/orgs/Lightning-AI/events', hooks_url: 'https://api.github.com/orgs/Lightning-AI/hooks', id: 58386951, issues_url: 'https://api.github.com/orgs/Lightning-AI/issues', login: 'Lightning-AI', members_url: 'https://api.github.com/orgs/Lightning-AI/members{/member}', node_id: 'MDEyOk9yZ2FuaXphdGlvbjU4Mzg2OTUx', public_members_url: 'https://api.github.com/orgs/Lightning-AI/public_members{/member}', repos_url: 'https://api.github.com/orgs/Lightning-AI/repos', url: 'https://api.github.com/orgs/Lightning-AI' }, pull_request: { _links: { comments: { href: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/issues/1559/comments' }, commits: { href: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/pulls/1559/commits' }, html: { href: 'https://github.com/Lightning-AI/lightning-thunder/pull/1559' }, issue: { href: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/issues/1559' }, review_comment: { href: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/pulls/comments{/number}' }, review_comments: { href: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/pulls/1559/comments' }, self: { href: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/pulls/1559' }, statuses: { href: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/statuses/09a17cd55ff9855292ca2062a05f7f2972383dc4' } }, active_lock_reason: null, additions: 70, assignee: null, assignees: [], author_association: 'COLLABORATOR', auto_merge: null, base: { label: 'Lightning-AI:main', ref: 'main', repo: { allow_auto_merge: true, allow_forking: true, allow_merge_commit: false, allow_rebase_merge: false, allow_squash_merge: true, allow_update_branch: true, archive_url: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/{archive_format}{/ref}', archived: false, assignees_url: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/assignees{/user}', blobs_url: 'https://api.github.com/repos/Lightning-AI/lightning-thunder/git/blobs
auto-cc
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636