Skip to content

Commit

Permalink
[pre-commit.ci] auto fixes from pre-commit.com hooks
Browse files Browse the repository at this point in the history
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Mar 26, 2024
1 parent 93ebc73 commit 128454b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion docs/source/basic/faq.rst
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,3 @@ The common solution is to represent programs in `SSA form <https://en.wikipedia.
There also exists the problem that some backends, like Triton and nvfuser, or a potential Jax backend, are not actually good at handling inplace operations either. They, like Thunder, expect functional programs, and if we simply decide to forward these operations to the executor, not every executor would be able to implement every operator. For a simple torch operator like ``x.add_(y)``, this is unsatisfactory to us. We would ideally like to be able to convert instances of ``add_()`` to ``add()`` for executors. But every trace needs to be executable.

We want to support inplace operations eventually, but we are attached to traces as our program representation of choice for optimization passes. Much like with dynamic shapes, if you have any ideas on how to best incorporate inplace operations, please let us know.

0 comments on commit 128454b

Please sign in to comment.