Skip to content

Commit

Permalink
Revert "disable flaky test (#1255)"
Browse files Browse the repository at this point in the history
This reverts commit 67d8df6.
  • Loading branch information
riccardofelluga committed Dec 14, 2024
1 parent 84ba13c commit 60219b3
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions thunder/tests/test_grad.py
Original file line number Diff line number Diff line change
Expand Up @@ -1493,9 +1493,6 @@ def test_populate_grads_mlp(executor, device, dtype):

@instantiate(dtypes=(thunder.float32,))
def test_populate_grads_csa(executor, device, dtype):
if version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0"):
pytest.skip("https://github.com/Lightning-AI/lightning-thunder/issues/1254")

from thunder.benchmarks import NanoGPTCSABenchmark, NanoGPTConfig

# NOTE Currently setting dropout to zero for reproducibility, other settings taken from gpt2 config
Expand Down Expand Up @@ -1523,9 +1520,6 @@ def test_populate_grads_csa(executor, device, dtype):

@instantiate(dtypes=(thunder.float32,))
def test_populate_grads_block(executor, device, dtype):
if version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0"):
pytest.skip("https://github.com/Lightning-AI/lightning-thunder/issues/1254")

from thunder.benchmarks import NanoGPTBlockBenchmark, NanoGPTConfig

# NOTE Currently setting dropout to zero for reproducibility, other settings taken from gpt2 config
Expand Down

0 comments on commit 60219b3

Please sign in to comment.