Skip to content

Commit

Permalink
remove _legacy_copy_params from add_transform
Browse files Browse the repository at this point in the history
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
  • Loading branch information
crcrpar committed Aug 21, 2024
1 parent 3548ba8 commit 76b910a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
6 changes: 0 additions & 6 deletions thunder/core/transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,6 @@ def add_transform(
*,
transform: Transform | list[Transform],
disable_torch_autograd_support=False,
_legacy_copy_params=False,
) -> Callable:
from thunder.common import CompileData

Expand Down Expand Up @@ -438,11 +437,6 @@ def add_transform(
disable_torch_autograd=cd.disable_torch_autograd_support or disable_torch_autograd_support,
**cd.compile_options,
)
from thunder import ThunderModule

if _legacy_copy_params and isinstance(jfn, ThunderModule):
jfn._overrides_parameters = cfn._overrides_parameters
jfn._overrides_buffers = cfn._overrides_buffers
return jfn


Expand Down
1 change: 0 additions & 1 deletion thunder/distributed/tensor_parallel/column_wise.py
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ def forward(self, tokens: torch.Tensor) -> torch.Tensor:
chunked_param_name_to_layer_type=chunked_param_name_to_layer_type,
process_group=process_group,
),
_legacy_copy_params=True,
)

return colwise_thunder_module
1 change: 0 additions & 1 deletion thunder/distributed/tensor_parallel/row_wise.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ def forward(self, tokens: torch.Tensor) -> torch.Tensor:
chunked_param_name_to_layer_type=chunked_param_name_to_layer_type,
process_group=process_group,
),
_legacy_copy_params=True,
)

return rowwise_thunder_module

0 comments on commit 76b910a

Please sign in to comment.