Skip to content

Commit

Permalink
versioning scheme for nightlies with dev (#1474)
Browse files Browse the repository at this point in the history
  • Loading branch information
t-vi authored Nov 26, 2024
1 parent 75a0d47 commit cd6977d
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion thunder/tests/test_dynamo.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ def func(x):
reason="Skip until the Torch bug is fixed - https://github.com/pytorch/pytorch/pull/139275",
),
pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0a99"),
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
),
),
Expand Down
4 changes: 2 additions & 2 deletions thunder/tests/test_grad.py
Original file line number Diff line number Diff line change
Expand Up @@ -1472,7 +1472,7 @@ def test_populate_grads_mlp(executor, device, dtype):

@instantiate(dtypes=(thunder.float32,))
def test_populate_grads_csa(executor, device, dtype):
if version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0"):
if version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0"):
pytest.skip("https://github.com/Lightning-AI/lightning-thunder/issues/1254")

from thunder.benchmarks import NanoGPTCSABenchmark, NanoGPTConfig
Expand Down Expand Up @@ -1502,7 +1502,7 @@ def test_populate_grads_csa(executor, device, dtype):

@instantiate(dtypes=(thunder.float32,))
def test_populate_grads_block(executor, device, dtype):
if version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0"):
if version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0"):
pytest.skip("https://github.com/Lightning-AI/lightning-thunder/issues/1254")

from thunder.benchmarks import NanoGPTBlockBenchmark, NanoGPTConfig
Expand Down
8 changes: 4 additions & 4 deletions thunder/tests/test_networks.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def test_nanogpt_mlp(executor, device, dtype):
executors=all_test_executors_and_dynamo,
decorators=(
pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0a99"),
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
),
),
Expand Down Expand Up @@ -285,7 +285,7 @@ def dummy(*args):


@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0a99"),
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/bitsandbytes-foundation/bitsandbytes/pull/1413",
)
@requiresCUDA
Expand Down Expand Up @@ -369,7 +369,7 @@ def test_quantization():


@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0a99"),
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
)
@thunder.tests.framework.requiresCUDA
Expand Down Expand Up @@ -424,7 +424,7 @@ def test_thunderfx_mistral_nemo_small():


@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0a99"),
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
)
@thunder.tests.framework.requiresCUDA
Expand Down
2 changes: 1 addition & 1 deletion thunder/tests/test_recipes.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_recipe_basic_bert():


@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0a99"),
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/Lightning-AI/lightning-thunder/issues/1471",
)
def test_recipe_basic_bert_dynamo():
Expand Down
6 changes: 3 additions & 3 deletions thunder/tests/test_transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def test_materialization():


@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0a99"),
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/bitsandbytes-foundation/bitsandbytes/pull/1413",
)
@pytest.mark.skipif(not package_available("bitsandbytes"), reason="`bitsandbytes` is not available")
Expand Down Expand Up @@ -190,7 +190,7 @@ def test_quantization_on_meta():


@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0a99"),
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/bitsandbytes-foundation/bitsandbytes/pull/1413",
)
@pytest.mark.skipif(
Expand Down Expand Up @@ -301,7 +301,7 @@ def f(x):


@pytest.mark.skipif(
version_between(torch.__version__, min_ver="2.6.0a0", max_ver="2.6.0a99"),
version_between(torch.__version__, min_ver="2.6.0dev0", max_ver="2.6.0a99"),
reason="https://github.com/bitsandbytes-foundation/bitsandbytes/pull/1413",
)
@pytest.mark.skipif(not package_available("bitsandbytes"), reason="`bitsandbytes` is not available")
Expand Down

0 comments on commit cd6977d

Please sign in to comment.