Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

look at transform_for_execution for generation torch compile callables #1131

Closed
t-vi opened this issue Sep 9, 2024 · 0 comments · Fixed by #1500
Closed

look at transform_for_execution for generation torch compile callables #1131

t-vi opened this issue Sep 9, 2024 · 0 comments · Fixed by #1500
Assignees
@t-vi
Labels
triage review

Comments

@t-vi
Copy link
Collaborator

t-vi commented Sep 9, 2024

Currently, the torch compile executors have their own way of creating callables operator by operator.
It would be more principled to use transform for execution to do so, however when #1041 tried, it needed to be reverted due to correctness issues. It would be good to find and fix the cause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-vi t-vi

Labels
triage review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use transform for execution to get torch_compile executable Lightning-AI/lightning-thunder
3 participants
@tfogal @t-vi @nvMelissa