use transform for execution to get torch_compile executable #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-vi
force-pushed
the
tom/torch_compile_transform_for_ex
branch
from
ebaf17f to
24d6a8d
Compare
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
| @@ -240,6 +240,23 @@ def split_forward_backward(computation_trc: TraceCtx, compile_data, compile_stat | |||
| skip_output=False, | |||
| skip_subsymbols=False, | |||
| ) | |||
|
|
|||
| # remove duplicates | |||
| # The NVFuser (and possibly others) fusion pass applied on the forward during has a | |||
There was a problem hiding this comment.
This is super interesting!
There was a problem hiding this comment.
Out of curiosity, do duplicates cause any functional issue?
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
mruberry
reviewed
Dec 3, 2024
lantiga
approved these changes
Dec 3, 2024
| return self.swap_map.get(variableify(v), v) | ||
|
|
||
| def add_unprocessed_bsyms(self, bsyms): | ||
| self.unprocessed_bsyms[:0] = bsyms |
There was a problem hiding this comment.
we could probably add self.unprocessed_bsyms and self.new_bsyms to __init__ for readability - not mandatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform for execution used to produce duplicate names, this changes the implementation to be close to interpret_trace (with the plan of merging the two eventually).
Unfortunately, there seems to be some bad interaction, the newly skipped tests have been leading to segfaults, this needs investigation.
Fixes: #1131
Also:
Fixes: #1501