You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it would be nice if we can leverage the OpInfo infra though I am not sure how it interacts for inplace operations (as currently all ops in opinfo are out-of-place).
We have some infra which uses OpInfo to generate a new list _inplace_opinfo for inplace ops by finding their corresponding inplace version. (Maybe we can directly add the OpInfo for setitem here?)
Currently we have a manual test at
lightning-thunder/thunder/tests/test_ops.py
Lines 242 to 253 in 1575797
and PR #1322 extends this test.
I think it would be nice if we can leverage the OpInfo infra though I am not sure how it interacts for inplace operations (as currently all ops in opinfo are out-of-place).
We have some infra which uses OpInfo to generate a new list
_inplace_opinfo
for inplace ops by finding their correspondinginplace
version. (Maybe we can directly add the OpInfo for setitem here?)lightning-thunder/thunder/tests/test_inplace_functionalization.py
Lines 108 to 109 in 1575797
cc @apaz-cli
The text was updated successfully, but these errors were encountered: