Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grad rule for copy_with_setitem #1322

Merged
merged 4 commits into from
Oct 29, 2024
Merged

grad rule for copy_with_setitem #1322

merged 4 commits into from
Oct 29, 2024

Conversation

kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Oct 17, 2024 •
edited
Loading

Fixes #1240

@tfogal
Copy link
Collaborator

tfogal commented Oct 28, 2024

Thanks for doing this, Kshiteej. I can confirm that this fixes #1340.

@kshitij12345 kshitij12345 mentioned this pull request Oct 28, 2024
Open
@kshitij12345 kshitij12345 marked this pull request as ready for review October 28, 2024 21:41
t-vi
t-vi approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kshitij12345 @tfogal

@t-vi t-vi enabled auto-merge (squash) October 29, 2024 08:56
@t-vi t-vi merged commit b28d5b3 into Lightning-AI:main Oct 29, 2024
41 checks passed
@kshitij12345 kshitij12345 deleted the copy_with_setitem-grad-rule branch October 29, 2024 09:52
tfogal pushed a commit that referenced this pull request Oct 29, 2024
@kshitij12345 @tfogal
grad rule for copy_with_setitem (#1322)
95a9c6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@tfogal tfogal tfogal approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VJP for PrimIDs.COPY_WITH_SETITEM is not implemented
3 participants
@kshitij12345 @tfogal @t-vi