-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Python 3.12 #763
Comments
gives
so that (without CACHE and RESERVED) is much probably the list of things to think about for testing ( |
CALL_INTRINSIC_2 and the remaining CALL_INTRINSIC_1 are about advanced typing. When we see this in the wild, we need to support it, but I didn't try running more than basic models yet. To my mind, none of this is critical right now, I filed #815 about exceptions during YIELD. |
We should look into Python 3.12 somewhat soonish:
The bulk of the work required probably can be inferred from the Python dis documentation by searching for 3.12 changes.
The list below is as of #767 which makes the test_interpreter on 3.12 pass and thus enables us to have CI checking the Thunder Python Interpreter.
END_FOR
END_SEND
BINARY_SLICE
,STORE_SLICE
RETURN_CONST
LOAD_LOCALS
LOAD_FROM_DICT_OR_GLOBALS
LOAD_FAST_CHECK
LOAD_FAST_AND_CLEAR
LOAD_FROM_DICT_OR_DEREF
CLEANUP_THROW
YIELD_VALUE
LOAD_ATTR
LOAD_SUPER_ATTR
(could be easy to map to calling super, but not 100% clear),CALL_INTRINSIC_1
(started)CALL_INTRINSIC_2
While the tests pass, clearly, they do not cover the unimplemented opcodes, so we should look into closing the delta for that.
For context, the Ubuntu 24.04 LTS uses Python 3.12.
The text was updated successfully, but these errors were encountered: