Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starting 3.12 compat, enable test_interpreter CI run for 3.12 #767

Merged
merged 17 commits into from
Jul 23, 2024
Merged

starting 3.12 compat, enable test_interpreter CI run for 3.12 #767

merged 17 commits into from
Jul 23, 2024

Conversation

t-vi
Copy link
Collaborator

@t-vi t-vi commented Jul 14, 2024 •
edited by github-actions bot
Loading

Towards fixing #763, but not quite there.
I propose to merge this PR enabling most of what we need and adds basic CI testing (like Python 3.11).
Then we can measure and fill in the gaps.

  • The jump logic has changed in how offsets are calculated (due to "CACHE" entries),
  • END_FOR
  • END_SEND
  • BINARY_SLICE, STORE_SLICE
  • RETURN_CONST
  • LOAD_LOCALS
  • LOAD_FROM_DICT_OR_GLOBALS
  • LOAD_FAST_CHECK
  • LOAD_FAST_AND_CLEAR
  • LOAD_FROM_DICT_OR_DEREF
  • CLEANUP_THROW
  • YIELD_VALUE
  • LOAD_ATTR
  • LOAD_SUPER_ATTR (could be easy to map to calling super, but not 100% clear),
  • CALL_INTRINSIC_1 (started)
  • CALL_INTRINSIC_2
  • removed opcodes need a max_ver=(3, 11)
  • changes in exception handling(?)
  • new internal datastructures?
  • add tests for opcodes we do not cover

Currently running test_interpreter.py in Python 3.12: 0 failed, 234 passed,

cc @Borda

@github-actions github-actions bot added the ci label Jul 20, 2024
@t-vi t-vi mentioned this pull request Jul 20, 2024
Open
18 tasks
@t-vi t-vi changed the title wip: starting 3.12 compat starting 3.12 compat, enable test_interpreter CI run for 3.12 Jul 20, 2024
@t-vi t-vi marked this pull request as ready for review July 20, 2024 20:26
@t-vi t-vi requested review from Borda, lantiga and mruberry as code owners July 20, 2024 20:26
lantiga
lantiga approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped!

@t-vi
Copy link
Collaborator Author

t-vi commented Jul 23, 2024

Failures seem unrelated.

@t-vi t-vi merged commit 6fe3b0c into main Jul 23, 2024
34 of 39 checks passed
@t-vi t-vi deleted the tom/python312 branch July 23, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

Assignees
No one assigned
Labels
ci install
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-vi @lantiga